Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-2325 Accessibility: Data guide code examples in plain text #33

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

dhgreene
Copy link
Contributor

Fixes BCDA-2325

Screen readers cannot parse images. Our code examples in the Data Guide are currently screenshots. The easiest way to make these accessible is placing them in plain text in a <code> block, which is the strategy employed by this PR.

Proposed Changes

  • Type out both code examples
  • Remove images

Security Implications

  • new software dependencies
  • security controls or supporting software altered
  • new data stored or transmitted
  • security checklist is completed for this change
  • requires more information or team discussion to evaluate security implications

No change is made in what information is shown.

Acceptance Validation

Before

Screen Shot 2020-02-26 at 12 02 37 PM

After

Screen Shot 2020-02-26 at 12 01 58 PM

Feedback Requested

  • Should we close the brackets in the second example?
  • Are there any typos?

Copy link
Contributor

@msnook msnook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhgreene dhgreene merged commit ca22d7f into master Feb 27, 2020
@dhgreene dhgreene deleted the dhg/BCDA-2325 branch February 27, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants