Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-2942: Standardize images in static site using style guide #54

Merged
merged 5 commits into from
Apr 21, 2020

Conversation

lianilychee
Copy link
Contributor

@lianilychee lianilychee commented Apr 15, 2020

Fixes BCDA-2942

This PR addresses the remaining 20 images in the sbx and prod non-technical guides that have the following inconsistent features:

  • Widths,
  • Resolution,
  • Swagger text sizing,
  • Annotation text sizing and colors, and
  • Annotation design elements sizing and colors.

Proposed Changes

  • Standardize the above features, and
  • Change imagery from PNG to SVG format

Change Details

See above section.

Security Implications

No PII / PHI is changed.

  • new software dependencies
  • security controls or supporting software altered
  • new data stored or transmitted
  • security checklist is completed for this change
  • requires more information or team discussion to evaluate security implications

Acceptance Validation

Tested locally.

Poor image:

Screen Shot 2020-04-16 at 11 57 23 AM

Replacement image:

Screen Shot 2020-04-16 at 12 18 03 PM

Feedback Requested

Review the non-technical guides for sbx and prod, and verifythat:

  • There are 25 images in each page rendering,
  • All imagery is crystal clear (no fuzziness), and
  • All text -- incl. Swagger text but esp. annotation text -- is readable.

…-technical user guides to reflect imagery changes.
…-technical user guides to reflect imagery changes.
@lianilychee lianilychee marked this pull request as ready for review April 16, 2020 17:20
@msnook
Copy link
Contributor

msnook commented Apr 20, 2020

This looks great to me, aside from the minor typo. The images are much nicer and more consistent. May I request that @Dave-Sukharan pull down this branch and spin it up locally, to ensure the walk-through has not regressed at all (i.e., extra set of eyes)?

Copy link
Contributor

@Dave-Sukharan Dave-Sukharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! A few minor changes:

  • Change circles in the first few images to rounded rectangles
  • Add text boxes to the end of the arrows
  • Small typo on final image

@Dave-Sukharan
Copy link
Contributor

Looks great! We caught all the typos and added those standardizations. Thanks Liani!

@msnook
Copy link
Contributor

msnook commented Apr 20, 2020

👍

@msnook msnook merged commit 9c6f025 into master Apr 21, 2020
@msnook msnook deleted the llye/BCDA-2942 branch April 21, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants