-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCDA-2942: Standardize images in static site using style guide #54
Conversation
…-technical user guides to reflect imagery changes.
…-technical user guides to reflect imagery changes.
This looks great to me, aside from the minor typo. The images are much nicer and more consistent. May I request that @Dave-Sukharan pull down this branch and spin it up locally, to ensure the walk-through has not regressed at all (i.e., extra set of eyes)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! A few minor changes:
- Change circles in the first few images to rounded rectangles
- Add text boxes to the end of the arrows
- Small typo on final image
Looks great! We caught all the typos and added those standardizations. Thanks Liani! |
👍 |
Fixes BCDA-2942
This PR addresses the remaining 20 images in the sbx and prod non-technical guides that have the following inconsistent features:
Proposed Changes
Change Details
See above section.
Security Implications
No PII / PHI is changed.
Acceptance Validation
Tested locally.
Poor image:
Replacement image:
Feedback Requested
Review the non-technical guides for sbx and prod, and verifythat: