Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify trait structure in the project #284

Closed
1 of 4 tasks
aborgna-q opened this issue Jul 26, 2023 · 0 comments
Closed
1 of 4 tasks

Simplify trait structure in the project #284

aborgna-q opened this issue Jul 26, 2023 · 0 comments
Assignees
@aborgna-q
Labels
breaking-change Changes that break semver

Comments

@aborgna-q
Copy link
Collaborator

aborgna-q commented Jul 26, 2023 •
edited
Loading

HugrView, HugrMut, AsMut, AsRef, Buildable, ...
#281 (comment)

Steps:
@aborgna-q aborgna-q self-assigned this Jul 26, 2023
@aborgna-q aborgna-q mentioned this issue Jul 26, 2023
Closed
@ss2165 ss2165 added the P-high label Jul 26, 2023
@aborgna-q aborgna-q mentioned this issue Aug 11, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 11, 2023
@aborgna-q
Add a root NodeHandle type param to HugrView (#398)
056da40 
I'll say this closes #380.

We could go further and add a type parameter in `Hugr<T: NodeHandle>`,
but that would probably be annoying to use and it'd break the pyo3
machinery.

Instead, most things should be interfacing via `HugrView`. #284 / #293
will move the builder references to views instead, so we will be able to
statically check the root type.
@aborgna-q aborgna-q mentioned this issue Aug 11, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 11, 2023
@aborgna-q
s/HugrMut/HugrInternalsMut/ as a sealed trait, and expose a minimal…
d272ed5 
… HugrMut (#402)

First step of #284 

Moves the mutating methods to a sealed trait, and makes `HugrMut` `pub`.
It also relates it to `HugrView` via a borrowing method.
@aborgna-q aborgna-q added the breaking-change Changes that break semver label Mar 14, 2024
@aborgna-q aborgna-q closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
breaking-change Changes that break semver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ss2165 @aborgna-q