Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Port over the SimpleOpEnum from tket2 #656

Closed
ss2165 opened this issue Nov 7, 2023 · 0 comments · Fixed by #721
Closed

feat: Port over the SimpleOpEnum from tket2 #656

ss2165 opened this issue Nov 7, 2023 · 0 comments · Fixed by #721
Assignees
@ss2165
Labels
enhancement New feature or request

Comments

@ss2165
Copy link
Member

ss2165 commented Nov 7, 2023

Generalise for shared easy functionality for extension op-sets that use c-style enums.
See: https://github.com/CQCL/tket2/blob/1f2b0b6e9cd12af79c713ba039319d6f9b42c07d/tket2/src/ops.rs#L53
@ss2165 ss2165 self-assigned this Nov 7, 2023
@ss2165 ss2165 added the enhancement New feature or request label Nov 7, 2023
@ss2165 ss2165 mentioned this issue Nov 24, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 29, 2023
@ss2165
feat!: OpEnum trait for common opdef functionality (#721)
74ff7ff 
BREAKING_CHANGES: const logic op names removd

Closes #656 

Have demonstrated with logic operations, pending comments on general
approach can port other larger extension op sets:
TODO:

- [x] Port logic.rs
- [ ] Port collections.rs
- [ ] Port int_ops.rs
- [ ] Port other arithmetic ops?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: OpEnum trait for common opdef functionality CQCL/hugr
1 participant
@ss2165