Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new "Gradients" scene to Color Correction and Tone Mapping #4

Merged

Conversation

allenwp
Copy link

@allenwp allenwp commented Sep 23, 2024

This PR adds a new "Gradients" scene to the color correction and tone mapping domo. This scene allows the user to see how different tone mappers behave over a range of values, which helps identify issues with hue shift, etc.

image
image
image
image

@allenwp allenwp force-pushed the add-color-correction-demo branch from a8a2734 to 49506bd Compare September 24, 2024 16:04
@allenwp
Copy link
Author

allenwp commented Sep 24, 2024

I've updated the PR to add an exponential scale option. This makes it easier to view the darker values:
image

@allenwp
Copy link
Author

allenwp commented Sep 24, 2024

And I've added one more scene that shows a saturated RGB hue gradient:
image

I will be honest, there are probably improvements that should be made regarding scene structure if this was to be merged as an official Godot demo project. For example, my controls could send signals instead of being hard-linked to various nodes.

I wanted to submit this PR to you as-is before spending a lot of time cleaning it up because I'm not sure if you want these sort of changes in your project in the first place.

@allenwp allenwp force-pushed the add-color-correction-demo branch 4 times, most recently from 92b52e0 to 8f63e7b Compare September 24, 2024 20:36
@Calinou Calinou force-pushed the add-color-correction-demo branch from be912cf to 0537563 Compare September 26, 2024 23:33
@Calinou Calinou added the enhancement New feature or request label Oct 11, 2024
@Calinou
Copy link
Owner

Calinou commented Oct 11, 2024

This looks great 🙂

Could you look into rebasing this to resolve merge conflicts so I can merge this?

@allenwp allenwp force-pushed the add-color-correction-demo branch from 8f63e7b to 4bbdf3c Compare October 11, 2024 19:45
@allenwp
Copy link
Author

allenwp commented Oct 11, 2024

Rebased, no conflicts!

@allenwp
Copy link
Author

allenwp commented Oct 11, 2024

I figure you will squash my commits into yours, but let me know if you’d prefer me to squash mine separate from yours.

@Calinou
Copy link
Owner

Calinou commented Oct 17, 2024

I figure you will squash my commits into yours, but let me know if you’d prefer me to squash mine separate from yours.

It's fine, I use Squash and merge here and the final PR will be squashed into a single commit anyway.

@allenwp
Copy link
Author

allenwp commented Oct 17, 2024

I see formatting checks are failing. I can reformat this at some point if you’d like.

@Calinou Calinou merged commit 22c8b46 into Calinou:add-color-correction-demo Oct 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants