🔒️ (feat): Add bundle signature verification #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into bundle_signing
WcaleNieWolny
commented
Aug 7, 2024
| @@ -1452,7 +1452,7 @@ public void appMovedToForeground() { | |||
| this._checkCancelDelay(false); | |||
| if ( | |||
| CapacitorUpdaterPlugin.this._isAutoUpdateEnabled() && | |||
| this.backgroundDownloadTask == null | |||
| (this.backgroundDownloadTask == null || !this.backgroundDownloadTask.isAlive()) | |||
There was a problem hiding this comment.
I think this just might solve #410
…into bundle_signing
WcaleNieWolny
changed the title
riderx
reviewed
Aug 16, 2024
| @@ -15,7 +16,7 @@ import Version | |||
| @objc(CapacitorUpdaterPlugin) | |||
| public class CapacitorUpdaterPlugin: CAPPlugin { | |||
| public var implementation = CapacitorUpdater() | |||
| private let PLUGIN_VERSION: String = "6.0.58" | |||
| private let PLUGIN_VERSION: String = "6.1.0" | |||
There was a problem hiding this comment.
Do not update yourself, let CI do it
riderx
reviewed
Aug 16, 2024
| @@ -81,6 +87,15 @@ public class CapacitorUpdaterPlugin: CAPPlugin { | |||
| implementation.statsUrl = getConfig().getString("statsUrl", CapacitorUpdaterPlugin.statsUrlDefault)! | |||
| implementation.channelUrl = getConfig().getString("channelUrl", CapacitorUpdaterPlugin.channelUrlDefault)! | |||
| implementation.defaultChannel = getConfig().getString("defaultChannel", "")! | |||
| do { | |||
| let signKeyString = getConfig().getString("signKey", "")! | |||
| if (!signKeyString.isEmpty) { | |||
There was a problem hiding this comment.
sign key should be optional
riderx
reviewed
Aug 16, 2024
| ); | ||
|
|
||
| this.sendStats("invalid_signature", version); | ||
| throw new GeneralSecurityException( |
riderx
reviewed
Aug 16, 2024
| @@ -55,7 +56,7 @@ public class CapacitorUpdaterPlugin extends Plugin { | |||
| private static final String channelUrlDefault = | |||
| "https://api.capgo.app/channel_self"; | |||
|
|
|||
| private final String PLUGIN_VERSION = "6.0.58"; | |||
| private final String PLUGIN_VERSION = "6.1.0"; | |||
|
Modifiy what asked and fix conflict then you can merge it yourself |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.