Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-4559: Create units with ancient parents #528

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

timorleph
Copy link
Contributor

This should finish the, somewhat unaccurately named, "censorship resistance" project.

Copy link

Please make sure the following happened

  • Appropriate tests created
  • Infrastructure updated accordingly
  • Updated existing documentation
  • New documentation created
  • Version bumped if breaking changes

Copy link
Contributor

@Marcin-Radecki Marcin-Radecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

There are two disabled tests, I tried to enable them on this branch, they pass but unfortunately I wrote them down in a way they do not test what they should be testing. I'll create ticket for fixing this

@timorleph
Copy link
Contributor Author

Also, activated the two tests you mention.

(Alsoalso I forgot to fmt, but I'm fixing that. :p)

@timorleph timorleph added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 496ff02 Jan 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants