Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] PR workflow: flake8 with forks #686

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

darodi
Copy link
Contributor

@darodi darodi commented Mar 9, 2022

[Project] pr workflow: flake8 with forks

@darodi darodi marked this pull request as draft March 9, 2022 20:08
@darodi darodi force-pushed the no_flake8_on_forks branch from a92949e to c20825a Compare March 9, 2022 22:08
@darodi darodi changed the title [Project] pr workflow: linters: don't auto fix issues from forks or dependabot [Project] pr workflow: flake8 with forks Mar 9, 2022
@darodi
Copy link
Contributor Author

darodi commented Mar 9, 2022

flake8 works on PR from a a fork with this change,
but we get an error later

image

@darodi darodi marked this pull request as ready for review March 9, 2022 22:19
@darodi
Copy link
Contributor Author

darodi commented Mar 9, 2022

fixed test-plugin-modules job

@darodi
Copy link
Contributor Author

darodi commented Mar 9, 2022

solution à la discussion dans #659

@joaopa00
Copy link
Contributor

Looks OK to me. Can you only change the title of the patch in [Project] PR workflow: flake8 with forks - fix test-plugin-modules
Thanks you for the work.

@darodi darodi force-pushed the no_flake8_on_forks branch from 3d6d33e to 77fb46d Compare March 10, 2022 00:24
@darodi darodi force-pushed the no_flake8_on_forks branch from 77fb46d to 1703286 Compare March 10, 2022 00:30
@darodi darodi changed the title [Project] pr workflow: flake8 with forks [Project] PR workflow: flake8 with forks Mar 10, 2022
@darodi
Copy link
Contributor Author

darodi commented Mar 10, 2022

done

mycanal flake8 fails... it's from another commit in dev

@joaopa00 joaopa00 merged commit 0f75e63 into Catch-up-TV-and-More:dev Mar 10, 2022
@darodi darodi deleted the no_flake8_on_forks branch March 10, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants