Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARE-550 Media Library improvements #3954

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

schaubes
Copy link
Collaborator

@schaubes schaubes commented Apr 27, 2023


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing (CI), if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer
  • Check that your pull request has been successfully deployed to https://web-test-1.catrob.at/

Additional Description

  • BREAKING: Renaming and refactoring of test commands to unify testing
  • show spinner until elements have loaded
  • remove thumb resize functionality as it was broken and seems unnecessary
  • remove jQuery

Tests - additional information

No additional information

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #3954 (7f4effa) into develop (2ef2e48) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #3954      +/-   ##
=============================================
- Coverage      50.02%   50.02%   -0.01%     
- Complexity      5713     5722       +9     
=============================================
  Files            654      656       +2     
  Lines          20474    20502      +28     
=============================================
+ Hits           10242    10256      +14     
- Misses         10232    10246      +14     
Flag Coverage Δ
behat 47.86% <0.00%> (+<0.01%) ⬆️
phpunit 8.70% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Controller/MediaLibrary/MediaPackageController.php 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@schaubes schaubes force-pushed the SHARE-550 branch 2 times, most recently from 5870a29 to 18f8ce5 Compare May 24, 2023 10:59
@schaubes
Copy link
Collaborator Author

@dmetzner Ich hab die npm Tests neu strukturiert und die PHP Tests hinzugefügt. Ich finds praktischer so, was haltest du davon?

@schaubes schaubes marked this pull request as ready for review May 24, 2023 13:08
@dmetzner dmetzner merged commit ad4a789 into Catrobat:develop May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants