Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARE-551 Privacy link in footer #4260

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Conversation

makne17
Copy link
Contributor

@makne17 makne17 commented Aug 25, 2023

Added privacy link to footer and adjusted translation files


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing (CI), if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer
  • Check that your pull request has been successfully deployed to https://web-test-1.catrob.at/

Additional Description

TODO: Add additional information that is not in your commit-message here

Tests - additional information

TODO: add additional information about testruns here

Added privacy link to footer and adjusted translation files
@makne17 makne17 self-assigned this Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #4260 (c3a62fa) into develop (40c76e1) will not change coverage.
Report is 5 commits behind head on develop.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #4260   +/-   ##
==========================================
  Coverage      49.70%   49.70%           
  Complexity      5771     5771           
==========================================
  Files            661      661           
  Lines          20646    20646           
==========================================
  Hits           10263    10263           
  Misses         10383    10383           
Flag Coverage Δ
behat 47.56% <ø> (ø)
phpunit 8.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -11,6 +11,7 @@ aboutPocketCode: 關於 Pocket Code
about: 關於
education: 教育
chat: 聊天和論壇
privacyGuide: 隱私意識指南
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked them in from crowdin manually?
You only have to add new translation to catroweb.en.yml
We have a translation team/community to translate those texts once the MR is merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Github Action syncs them every day.

@dmetzner dmetzner self-requested a review September 1, 2023 12:25
@dmetzner dmetzner merged commit 749f3d2 into Catrobat:develop Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants