-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHARE-551 Privacy link in footer #4260
Conversation
Added privacy link to footer and adjusted translation files
Codecov Report
@@ Coverage Diff @@
## develop #4260 +/- ##
==========================================
Coverage 49.70% 49.70%
Complexity 5771 5771
==========================================
Files 661 661
Lines 20646 20646
==========================================
Hits 10263 10263
Misses 10383 10383
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Added privacy link to footer and adjusted translation files
Added privacy link to footer and adjusted translation files
@@ -11,6 +11,7 @@ aboutPocketCode: 關於 Pocket Code | |||
about: 關於 | |||
education: 教育 | |||
chat: 聊天和論壇 | |||
privacyGuide: 隱私意識指南 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked them in from crowdin manually?
You only have to add new translation to catroweb.en.yml
We have a translation team/community to translate those texts once the MR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Github Action syncs them every day.
Added privacy link to footer and adjusted translation files
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.
SHARE-666 The devils ticket
Code Review
section in JiraAdditional Description
TODO: Add additional information that is not in your commit-message here
Tests - additional information
TODO: add additional information about testruns here