Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup deps for forest/stable-rust-toolchain #116

Merged
merged 2 commits into from
May 22, 2023
Merged

Conversation

aatifsyed
Copy link
Contributor

@aatifsyed aatifsyed commented May 22, 2023

Summary of changes
Changes introduced in this pull request:

  • remove fvm, it wasn't used in these crates at all. Surprised we don't check for unused deps with e.g cargo-udeps, which would have stopped this situation.
  • bump fvm_shared

Reference issue to close (if applicable)

Closes

Other information and links

@CLAassistant
Copy link

CLAassistant commented May 22, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aatifsyed aatifsyed changed the title fvm erroneously locked fixup deps May 22, 2023
@aatifsyed aatifsyed changed the title fixup deps fixup deps for forest/stable-rust-toolchain May 22, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (38903b4) 9.55% compared to head (7f33400) 9.55%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #116   +/-   ##
=====================================
  Coverage   9.55%   9.55%           
=====================================
  Files        311     311           
  Lines      28695   28695           
=====================================
  Hits        2741    2741           
  Misses     25954   25954           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lemmih
Copy link
Collaborator

lemmih commented May 22, 2023

We are using cargo udeps but, unfortunately, it doesn't work well with workspaces.

@lemmih lemmih merged commit 5aaae19 into main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants