Align Forest and Lotus send behavior
#2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lemmih
reviewed
Apr 11, 2023
lemmih
reviewed
Apr 11, 2023
lemmih
reviewed
Apr 11, 2023
lemmih
reviewed
Apr 11, 2023
lemmih
reviewed
Apr 11, 2023
lemmih
reviewed
Apr 11, 2023
lemmih
reviewed
Apr 11, 2023
lemmih
reviewed
Apr 11, 2023
This comment was marked as resolved.
This comment was marked as resolved.
lemmih
requested changes
Apr 15, 2023
lemmih
requested changes
Apr 18, 2023
lemmih
requested changes
Apr 24, 2023
lemmih
approved these changes
May 2, 2023
elmattic
reviewed
May 2, 2023
elmattic
reviewed
May 2, 2023
| let amount = "42fiascos"; | ||
| assert_eq!( | ||
| FILAmount::from_str(amount).unwrap_err().message(), | ||
| "failed to parse fil amount: 42fiascos. Unrecognized suffix." |
There was a problem hiding this comment.
It would be nice to put in the error message the offending suffix as well.
elmattic
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
FILin all units supported in Forest wallet in the amount specified in thesendcommand. Subtasks:Update the documentation accordingly.(will be covered under issue Documentforest sendin the user's-guide and in the README #2029 )Make sure(will be covered under another PR)sendFILstill works in the JavaScript consoleReference issue to close (if applicable)
Closes associated tasks in issue #2668
Other information and links
Task to update documentation will be covered under issue #2029 and task to add support for multiple units in JavaScript console will be covered under another PR tied to issue #2668.
Change checklist
(if possible),
CHANGELOG is
up-to-date. All user-facing changes should be reflected in this document.