-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve forward raytrace to better find all images #264
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #264 +/- ##
==========================================
+ Coverage 93.36% 93.46% +0.09%
==========================================
Files 59 59
Lines 2775 2829 +54
==========================================
+ Hits 2591 2644 +53
- Misses 184 185 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I am well suited to review this. I don't really work with micro lensing. You could ask Nolan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool algorithm! Just had a couple questions about the behavior in the tutorial notebook.
@NolanSmyth It should be ready now, what do you think? |
No description provided.