Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve forward raytrace to better find all images #264

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

ConnorStoneAstro
Copy link
Member

No description provided.

@ConnorStoneAstro ConnorStoneAstro added docs Improvements or additions to documentation fix A bug fix patch for the codebase perf A code change that improves performance labels Sep 26, 2024
@ConnorStoneAstro ConnorStoneAstro linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.46%. Comparing base (e8e45bf) to head (652370c).
Report is 69 commits behind head on dev.

Files with missing lines Patch % Lines
src/caustics/lenses/base.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #264      +/-   ##
==========================================
+ Coverage   93.36%   93.46%   +0.09%     
==========================================
  Files          59       59              
  Lines        2775     2829      +54     
==========================================
+ Hits         2591     2644      +53     
- Misses        184      185       +1     
Flag Coverage Δ
unittests 93.46% <97.05%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AlexandreAdam AlexandreAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I am well suited to review this. I don't really work with micro lensing. You could ask Nolan.

Copy link
Collaborator

@NolanSmyth NolanSmyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool algorithm! Just had a couple questions about the behavior in the tutorial notebook.

@ConnorStoneAstro
Copy link
Member Author

@NolanSmyth It should be ready now, what do you think?

@ConnorStoneAstro ConnorStoneAstro merged commit ecbda4e into dev Sep 26, 2024
13 checks passed
@ConnorStoneAstro ConnorStoneAstro deleted the fwdraytracebetter branch September 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix A bug fix patch for the codebase perf A code change that improves performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS Review: Point Source Docs + Expand on limitations
3 participants