Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle q=1 for sie #301

Merged
merged 4 commits into from
Jan 25, 2025
Merged

fix: handle q=1 for sie #301

merged 4 commits into from
Jan 25, 2025

Conversation

ConnorStoneAstro
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (ac2c427) to head (d8e4be6).
Report is 19 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #301   +/-   ##
=======================================
  Coverage   91.91%   91.92%           
=======================================
  Files          55       55           
  Lines        2277     2279    +2     
=======================================
+ Hits         2093     2095    +2     
  Misses        184      184           
Flag Coverage Δ
unittests 91.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ConnorStoneAstro ConnorStoneAstro changed the title handle q=1 for sie fix: handle q=1 for sie Dec 20, 2024
@ConnorStoneAstro ConnorStoneAstro added the fix A bug fix patch for the codebase label Dec 20, 2024
@ConnorStoneAstro ConnorStoneAstro linked an issue Dec 21, 2024 that may be closed by this pull request
Copy link
Collaborator

@mjyb16 mjyb16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on the numerical stability issues. I will be testing this on real data soon so if something crops up we can patch.

@ConnorStoneAstro ConnorStoneAstro merged commit ea277ed into dev Jan 25, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix patch for the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIE not valid at q=1
2 participants