Only list images when their use case is not skipped #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgantasp
force-pushed
the
avoidPermissionWhenNotNeeded
branch
from
bf1aa7e to
53a0d1b
Compare
|
If you look at line 17 that value is then used to do the validation and tag or not, so this implementation would break that. |
georgantasp
force-pushed
the
avoidPermissionWhenNotNeeded
branch
from
53a0d1b to
20b88d6
Compare
|
@marboledacci you're right, I let the double negative confuse me. I pushed a fix to make it make sense. Now, the |
marboledacci
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation, issues
My CI AWS profile is given an aws managed policy which does not have
ecr:ListImagespermission. EC2InstanceProfileForImageBuilderECRContainerBuildsDescription
The
tag_imagecommand has a flag toskip_when_tags_exist(default false). When the flag is not set, there is no use for theListImagesoutput.