Future ideas for speed limit tool (scope creep from PR 1168)

[originalfoo]

Future ideas and scope creep gathered from PR #1168:
The reference branch is here https://github.com/kvakvs/TMPE/tree/u-speedlimits-tool-feature-creep

Features

• Icon overlay fade - only when nearing max distance from cam?
• Noticed that speed icons in lane mode are bigger than those in segment mode - if anything should be other way
  round, but ideally should be same size in both modes. - will be fixed by Themed default speed signs (redux) #1404
  
  
• Speed limits: Allow lanes/roads to be clicked (not just icons) #925 - Allow lanes/roads to be clicked (not just icons)
• kvakvs: I had this idea to replace numbers in speed palette with actual textures in an atlas, and I am OK to have
  a theme switch as a button and dropdown menu or something simplistic. We probably do not need an entire new window for
  that, its just an MPH switch and theme dropdown, 2 controls.
  • Load signs theme texture into Atlas and use for buttons

Improvements to UI

• Minimal effort: options checkbox to show country theme signs instead of default signs in the default SpeedLimits view. Some users are getting confused by the green field of default signs. - will be fixed by Themed default speed signs (redux) #1404
• Mouse wheel:
  • when in speed window, mouse wheel to cycle the selected speed
  • when over a sign in overlay, could adjust speed of that specific sign?
• Disable speed shortcuts (mod option) - possibly limit to disabling the Alt+0..9 ones?
• (Minor) add some kind of feedback to the user that shown speed limit is averaged value when one or more lanes have
  different speed.
  • Maybe: Use basic circle icon (similar to default speeds, but different colour/shape)?
  • Or, rotate the icon by 45 degrees? Or make bigger than normal?
  • Or, force per-lane speed display on segments that have lanes with different speeds? (might clutter overlay tho)
• OSD - Merge Increase/Decrease shortcuts on to one line, so the Alt shortcuts can be moved to it's own line?
  
• BoundingBoxContribution to become enum (True, False, OnlyHeight, OnlyWidth)
• Highlight entire segments for segment ops Inconsistent highlighting when changing speed limits per road type #1246
• Now we have distinct icon themes, would be nice if chosen theme was reflected in the toolbar (eg. priority signs button shows Yield.png, speed limits button shows 30.png, and parking restrictions button shows Parking.png).

UI problems

• BUG: If speed window loses focus the key shortcuts stop working again - steps to reproduce:
  Open speed tool - shortcuts work fine Click (?) on TMPE main toolbar - speed shortcuts stop working (until a button on
  speed bar is clicked)
• Remove circle backgrounds from buttons (seg vs. lane, and defaults) at side of speed window? (Debatable, as button
  style for TM:PE uses circles).
• Treat Ø as a speed button:
  • Move button to end of speed bar (eg. after 90mph) so it's logical progression 0 -> 90 -> unlimited
  • Right align under-button hint text for that button
    • Allow text labels to be right aligned, aligned to anchor control's right edge?
  • Have it change size in same way the other speed buttons do
  • Include in speed cycling shortcuts (could possibly ditch the /,\ shortcuts?)

[originalfoo]

Speed overlay signs seem bigger in lane mode than they are in segment mode.

[originalfoo]

Find It mod - issue regarding it trapping Alt+1..0 shortcuts - sway2020/FindIt2#135

[originalfoo]

very low pri: Allow dragging of speed window by the bottom (button hint area)?

[originalfoo]

If speed window loses focus the key shortcuts stop working again - steps to reproduce:

1. Open speed tool - shortcuts work fine
2. Click (?) on TMPE main toolbar - speed shortcuts stop working (until a button on speed bar is clicked)

[originalfoo]

Remove circle backgrounds from buttons (seg vs. lane, and defaults) at side of speed window?

[originalfoo]

Allow setting defaults per-lane? Probably a huge change tho...

Example use cases:

• Setting slower outer lanes on large roads to promote traffic using faster inner lanes
• Setting slow 'local route' lanes on roads with multiple medians (eg. An option to enhance the behavior of the Can Cross Lanes road asset flag #1220 (comment) )

[originalfoo]

OSD - Merge Increase/Decrease shortcuts on to one line, so the Alt shortcuts can be moved to it's own line ?

[originalfoo]

Find It v2.7.3-beta1 now disables its secondary shortcuts (Alt+0..9) when the Find It toolbar is not open:

• Secondary keyboard shortcuts are now disabled by default when Find It 2 is closed
  These shortcuts (Alt + 0-9/V) will only function when Find it 2's panel is opened
  Main keyboard shortcut (Ctrl + F) is unaffected

sway2020/FindIt2#135

[originalfoo]

#925 - Allow lanes/roads to be clicked (not just icons)

[originalfoo]

Did this get included: #988

[kvakvs]

Did this get included: #988

i believe this was quick-fixed soon after report, you can check the constants file

[originalfoo]

From #1215 (comment) :

How much scope is there for UI change in this PR? I'm finding the current way it works to be a bit... clunky, particularly as the mph vs. km/h checkbox can change based on which theme is chosen, and when clicking the in-game mph / km/h button I can sometimes get an unexpected theme and then end up having to go in to mod options anyway = ugh.

Would it be better to have the theme selection done entirely via the in-game UI, for example:

• Open speeds tool: If first use (or config theme id not found / invalid) switch UI to "select theme" mode:
  • Window title bar text: "Select speed icon theme"
  • Speed bar gets replaced with an icon theme bar - eg. 30.png icon from each theme, arranged in a row
  • Alternatively, mph themes could show 30.png and km/h themes could show 50.png = easy visual cue to the speed unit
  • If, at later date, there's too many themes, we can add scroll buttons or more rows or whatever
  • Over/Under-button hint text shows (top) mph or km/h and (bottom) country
  • Countries with both mph and km/h would get two entries in the theme bar
  • User clicks desired icon - that theme is loaded and UI switches to speed bar mode
• In speed bar mode, clicking the mph / km/h button (it's tooltip could be smth like "Select speed icon theme") goes to select theme mode

This way user is prompted to set theme on first use of tool, and sign selection is visual - rather than drop-down list vs. checkbox. And when trying out different themes, there's no need to keep going in to mod options.

From #1215 (comment) :

I had this idea to replace numbers in speed palette with actual textures in an atlas, and I am OK to have a theme switch as a button and dropdown menu or something simplistic. We probably do not need an entire new window for that, its just an MPH switch and theme dropdown, 2 controls.

[originalfoo]

Noticed that speed icons in lane mode are bigger than those in segment mode - if anything should be other way round, but ideally should be same size in both modes.

Edit: Same issue in overground view btw.

Will be fixed by #1404

[kianzarrin]

@aubergine10 about hotkey conflicts with Find it. one solution would be for both FindIT and TMPE to register hotkeys to UUI. that way UUI is able to resolve hotkey conflicts (active tool takes priority). you don't even need to have a UUI button.

[originalfoo]

@kianzarrin Find It has already been updated so its category hotkeys aren't global by default.

[kianzarrin]

@aubergine10 yeah I noticed but just to let you know for future. BTW TMPE stay-in-lane seems to conflict with FRT node snapping. I told klyte about this.

[originalfoo]

Now we have distinct icon themes, would be nice if chosen theme was reflected in the toolbar (eg. priority signs button shows Yield.png, speed limits button shows 30.png, and parking restrictions button shows Parking.png).

[krzychu124]

User request (more or less) 🤣

I admit that normal view (not defaults) could show only sign textures from theme (maybe togglable in the options).
I'm pretty sure that current solution may confuse users, but works perfectly for debugging which is great addition. Having the old view + themes could make them really happy with the least effort from our side

[originalfoo]

There's been a few users commenting along those lines.

If we add a new mod option, maybe it should be 'off by default', something like:

( ) Use un-themed green signs for default speeds in normal view

So by default the normal view will always show themed signs regardless of whether they are default speed or custom speed override.

Maybe we could do an 11.6.5 release with that in? Fixed by #1404

[originalfoo]

Option added:

Now just need to work out where in the speed limits code determines which icon to show. Fixed by #1404