Themed default speed signs (redux)

[originalfoo]

Compiled mod for testing: TMPE.zip

This is a redux of #1320

Changes to speed limits overlay:

• Segment and lane modes now always use themed icons (defaults mode still always shows unthemed icons).
• If user customises a speed to value other than network default, a green sub-icon is appended to the themed speed sign.

Example:

That sub-icon is only shown in interactive mode, when used has customised the speed to non-default value, but only if a mod option is enabled in Overlays tab:

Todo:

• Apply same thing to lane mode
• Persist option to savegame
• Fix size of lane mode icons (similar to Themed default speed signs #1320)
• Test with monorail in lane mode (which adds passenger train sub-icon)

Updates: #1221 (comment)

[originalfoo]

An alternative is to show the green sub-icon (complete with speed value) on non-default speeds, and maybe have mod option to toggle whether it's shown at all?

I'm thinking tht would be much better approach acutally. And have the option disabled by default.

Now actually going to get some sleep.

[kvakvs]

I would say it does not matter where and how you show the default green icon, this is a case of bikeshedding. Just show the default somewhere. Need an option to hide it - fine, you already had that implemented.

[originalfoo]

ready for review

[krzychu124]

Some themes does not play well with default 😕

[originalfoo]

Ah, good catch, it's currently using same aspect ratio as the themed sign. Hopefully easy to fix, brb...

[originalfoo]

Ok, try that :)

[krzychu124]

Code looks ok, tested in-game.

[originalfoo]

@kvakvs any feedback?

[kvakvs]

Me likey