Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lane connector: Separate road vs. tracked connections #354

Closed
2 of 4 tasks
Tracked by #1479
originalfoo opened this issue Jun 2, 2019 · 7 comments · Fixed by #1550
Closed
2 of 4 tasks
Tracked by #1479

Lane connector: Separate road vs. tracked connections #354

originalfoo opened this issue Jun 2, 2019 · 7 comments · Fixed by #1550
Assignees
Labels
discussion Contains debate on certain topics enhancement Improve existing feature LANE ROUTING Feature: Lane arrows / connectors
Milestone

Comments

@originalfoo
Copy link
Member

originalfoo commented Jun 2, 2019

Description

Using lane connector tool, tram track lanes can only be connected to other tram track lanes.

However, in most cases the tram track lane is also a road or bus lane. It would be nice if we could connect the non-tram traffic to any other traffic lane.

Maybe we could have two shapes on incoming lanes:

  • Circle = the connector for road vehicles
  • Rectangle = connector for tracked vehicles

This way we could still allow road vehicles to connect to any outgoing road lane, and the tracked (eg. tram, usually) vehicle would be limited to outgoing lanes containing same type of track.

Screenshots (Optional)

Example of a road that has tram+bus lanes - it's not possible to connect those bus lanes to the bus lanes on adjoining road.

255710_screenshots_20190601215741_1

tasks:

@originalfoo originalfoo added feature A new distinct feature triage Awaiting issue categorisation discussion Contains debate on certain topics enhancement Improve existing feature and removed feature A new distinct feature triage Awaiting issue categorisation labels Jun 2, 2019
@originalfoo originalfoo added the LANE ROUTING Feature: Lane arrows / connectors label Aug 12, 2019
@originalfoo
Copy link
Member Author

In addition to different shape, we'd also need to offset (closer or further from junction) the track shapes from where the road shapes usually appear.

Also there is possibility of a "lane area" containing two tracks, for example a monorail lane over tram lane over road lane. So possibly offset and shape would be based on network type?

Some ideas on shapes (no idea if these are feasible):

  • Circle = road
  • Square = tram
  • Triangle = monorail / train / metro (assumption: we'll never have more than one of those networks in the same position on a road)

@kianzarrin
Copy link
Collaborator

We should use the alt modifier to hide road circle markers. This helps to select rectangular tracks. road selection takes priority.

@originalfoo
Copy link
Member Author

That will also solve #353 and would possibly remove the need to differentiate between lane types too #295

@kianzarrin
Copy link
Collaborator

kianzarrin commented Apr 26, 2022

@aubergine10 @krzychu124 so far (in #1501) I have laid the foundation of the code such that trolleybuses use the same lane connection as cars vehicles and not track vehicles. That means trolleybuses will use the same lane connections as cars. is that OK?

@krzychu124
Copy link
Member

I think so. Perfect solution would be a dedicated lane connector (buses/trolleybuses) but I don't think there is a demand for it (they lived with limitations so...)

@kianzarrin
Copy link
Collaborator

I don't think it would be too hard to implement. we need a new transition group: bus.
Routing manager needs a dedicated code-path to route buses but the rest of the code needs minimal changes.

@originalfoo
Copy link
Member Author

Also take in to consideration the intercity buses which essentially route themselves to their desired intercity bus stop - do they need handling different to other buses?

@kianzarrin kianzarrin self-assigned this Apr 27, 2022
@kianzarrin kianzarrin linked a pull request Apr 27, 2022 that will close this issue
22 tasks
originalfoo added a commit that referenced this issue May 22, 2022
- [Meta] This release adds a new language, updates translations, and improves lane routing
- [New] Veitnamese translation #1551 (DucAnhLam)
- [Updated] Separate road and track lane routing #1550 #1546 #1545 #354 (kianzarrin)
- [Updated] Translations for multiple languages #1551 #1344 (Nguyễn Tài Đức, OldEj, AduitSSH, Chamëleon, 문주원, krzychu124, shg166, John Lok Ho, Márcio Saeger, DucAnhLam, DNSE, Arne Peirs, Neoone, Fatih YILDIRIM, Zeldslayer, GiorgioHerbie, krzychu124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Contains debate on certain topics enhancement Improve existing feature LANE ROUTING Feature: Lane arrows / connectors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants