Scale unity GUI #1152
Scale unity GUI #1152
Conversation
kianzarrin
added
UI
Just bump up GlobalConfig version and mod will recreate it with new settings
I don't understand your concern 🤔 Anyways I'll test it later today 😉 |
TLM/TLM/U/UIScaler.cs
Outdated
| @@ -49,14 +49,14 @@ public static class UIScaler { | |||
| public static float MaxWidth { | |||
| get { | |||
| float ret = Config.GuiScaleToResolution ? BaseResolutionX : Screen.width; | |||
| return ret / Config.GuiScale; | |||
| return ret / (Config.GuiScale * 0.01f); | |||
There was a problem hiding this comment.
no magic numbers plz. make the 0.01f a variable.
There was a problem hiding this comment.
@kianzarrin I don't remember what range GuiScale is (probably 30...200+) but if it's percentage then it does not look right to me. For 100 it will return ret/1f which is ok, but for 200 it will be ret/2f, so 2x smaller?? 🤔
TLM/TLM/U/UIScaler.cs
Outdated
| } | ||
| } | ||
|
|
||
| public static float MaxHeight { | ||
| get { | ||
| float ret = Config.GuiScaleToResolution ? BaseResolutionY : Screen.height; | ||
| return ret / Config.GuiScale; | ||
| return ret / (Config.GuiScale * 0.01f); |
| @@ -142,6 +143,8 @@ public SpeedLimitsTool(TrafficManagerTool mainTool) | |||
|
|
|||
| public override void OnToolGUI(Event e) { | |||
| base.OnToolGUI(e); | |||
| var oldMatrix = GUI.matrix; | |||
| GUI.matrix = UIScaler.ScaleMatrix; | |||
There was a problem hiding this comment.
what is this matrix switching thing?
currently on the train, can't look it up easily.
is GUI.matrix our code?
if not and we can't change it than this is ok.
if its ours we really should change it :)
There was a problem hiding this comment.
GUI.matrix is Unity code for immediate gui, works pretty much like GUI.color, but obviously changes different thing 😉
There was a problem hiding this comment.
kk .. in that case the code is fine.
| @@ -308,6 +309,8 @@ public TimedTrafficLightsTool(TrafficManagerTool mainTool) | |||
|
|
|||
| public override void OnToolGUI(Event e) { | |||
| base.OnToolGUI(e); | |||
| var oldMatrix = GUI.matrix; | |||
| GUI.matrix = UIScaler.ScaleMatrix; | |||
There was a problem hiding this comment.
same as for speedlimitstool.
TLM/CSUtil.Commons/Log.cs
Outdated
| File.Delete(LogFilePath); // delete old file to avoid confusion. | ||
| } | ||
|
|
||
| var args = Environment.GetCommandLineArgs().ToList(); |
There was a problem hiding this comment.
No need to convert ToList() here since you don't use it as a list further down in the method.
Better to keep it a string array and use Array.FindIndex(args, a => a == "-logFile") in the next line.
There was a problem hiding this comment.
this is not part of this review. I updated the branch
fixes #573
Speed limit tool and TTL now have constant size regardless of resolution (+ minor bug fixes)
To test this you need to remove TMPE_GlobalConfig.xml or set GuiScaleToResolution to true.
we have not released this so it won't be an issue for WS users but what about testers?
TMPE.zip