Simplify UI scaler

[kianzarrin]

No description provided.

[DaEgi01]

I'd reduce GetAView() calls to a minimum.
Call it once and cache it.
The method searches every time for the first UIView even though the value never changes.
Also the method is implemented via LINQ and will cause heap allocations each time.

[kvakvs]

Renaming config option will reset scale for everyone.

[DaEgi01]

Renaming config option will reset scale for everyone.

I see, how do we handle that?

1. we don't care about the user?
2. we don't care about the code?
   :D

[kvakvs]

I see, how do we handle that?
1. we don't care about the user?
2. we don't care about the code?

Reasonable default for example 100% zoom

or keep old variable, give new variable default -1 for example, and if it is -1, we migrate value to new on the first load. This migration code can be removed in the next release.

[DaEgi01]

I see, how do we handle that?

1. we don't care about the user?
2. we don't care about the code?

Reasonable default for example 100% zoom

or keep old variable, give new variable default -1 for example, and if it is -1, we migrate value to new on the first load. This migration code can be removed in the next release.

To be honest, in that case I'd probably leave the variable name as is since its too much hastle for too little gain. I did not consider that when I proposed to rename the variable. But your solution also sounds fine. I don't mind either solution in this case .. since they all have some little drawback.

[krzychu124]

👍