Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Segment End API #1689

Merged
merged 5 commits into from
Nov 23, 2022
Merged

Get Segment End API #1689

merged 5 commits into from
Nov 23, 2022

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Nov 17, 2022 •
edited
Loading

I think ExtSegmentEndManager is exposing too much detail. instead of exposing GetIndex() and ExtSegmentEnds array its to introduce an API method that hides this complexity from user.
Code is self explanatory and is unused from inside TMPE.

@kianzarrin kianzarrin added low priority Issue with low priority of work API API for external mods labels Nov 17, 2022
@kianzarrin kianzarrin self-assigned this Nov 17, 2022
@krzychu124 krzychu124 added this to the 11.8.0 milestone Nov 17, 2022
krzychu124
krzychu124 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested.

@kianzarrin kianzarrin merged commit bd36db2 into master Nov 23, 2022
@krzychu124 krzychu124 modified the milestones: 11.8.0, 11.7.3.0 Nov 23, 2022
@kianzarrin kianzarrin deleted the GetSegmentEnd branch November 23, 2022 17:04
@krzychu124 krzychu124 mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

Assignees

@kianzarrin kianzarrin

Labels
API API for external mods low priority Issue with low priority of work
Projects
None yet
Milestone
11.7.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kianzarrin @kvakvs @krzychu124