Turn On Red (Previously Right On Red) #25
Conversation
|
Is it bug less? 😄 |
FireController1847
force-pushed
the
1.10.15
branch
from
4d6a048 to
f084937
Compare
I have been playing with it for a while now and it seems to work well. However there are a few things to be done (see the TODO comments). I've seen the separate workshop mod as well, however I feel like this is 1) much more fitting for this mod and 2) I was unable to get the other mod to work with TM;PE. |
|
You mean this?
Would be nice to resolve some of them before merging :) |
|
I'll try and find some time this week to see if I can't resolve some of those. However with some of those I may be unable to, since I'm still learning how this mod works in its entirety. I'm pretty sure one-way roads won't be that hard, same with wreckless drivers. The cutting into the flow of traffic might be a little harder though. I'll take my best shot when I get the chance Also, in the future I'd love to help out with more features. One in particular I've been thinking of is having the cars pull over when there's an emergency vehicle near them, although that one would be a lot more complicated than this would be (considering I had a guide with this one also xD) |
|
Don't worry I'm still learning too. Codebase of this game is huge and sometimes complicated :) |
It is extremely complicated. Like, why are there over 15 classes just to control chirper? And WHY are events tied so deeply into the messages for chirper? Even with that, there's no generic list of messages for each event? And that's just one example. 😫
That sounds awesome, I'd love to see an example of how to debug and place breakpoints. Heh, I spent more time than I'd like to admit figuring out that it logs to a file called "TMPE.log" in the game directory, as well as how to enable debugging. 😃 |
|
I've fixed two of the four checks. I might be able to work on the other ones tomorrow, and I've got an idea on how to do it. |
|
Okay, I'm kind of at a loss, and I have a few questions that you might or might not be able to answer.
I need to know these since this is how I plan on detecting the amount of space to make a turn, and if it is "safe" to make that turn. Other than that, all the other issues have been fixed :) |
* On a 3-way road, when there is a road going straight and one branching off, you can't go straight if the light is red. * On a one-way road, if you're going straight, you can't go straight if the light is red. * Add better checks for future bugs.
FireController1847
force-pushed
the
1.10.15
branch
from
d6b832e to
474528a
Compare
* When detecting if the vehicle is going straight, change from comparing the vehicle's position to the vehicle's turning road (the right or left) to comparing the vehicle's position with the target road (the road the vehicle is going to). * Compare both the start and end segments when detecting straightness.
|
If I find some time tomorrow I will try to answer few of your questions because currently I am busy and I have no time for searching and analysis. Moreover I didn't even started learning how path fining algorithm really works. It's quite complicated as you know. Iwill try to find some time and make some notes |
|
No worries! I'll also keep digging and see if there's anything I've missed while looking through the code. |
There was a problem hiding this comment.
I found small issues in your code, but nothing critical yet 😉
Besides that I have one problem. After disabling this feature from mod options menu I can still see these signs while I'm clicking on node in Junction restrictions mode. BTW you should add visibility condition when selected node has no traffic lights (automated, manual, vanilla - doesn't matter). I think there is no point do display feature controls when there is no traffic lights 😄
Tell me what do you think about my suggestions.
|
Another issue 😉 As you can see it would be great to hide this sign if there is no right turn 😄 |
|
#33 (comment) |
* Hopefully it's alright if I used Google Translate
* I spent some time in Photoshop to create icons that I felt fit in much better with the current ones. * I added an option in segments to check if the segment has a preferred segment (segment to the right on a red light, for example). * Fixed junction restrictions for turn-on-red * Change the option name and position in the options menu * Only show the junction restriction when it applies
|
Hopefully the latest commit solves almost all of your review requests. I've also created some cool looking signs for this. Here's the PSD files I used to make them, as it provides an easy template for making future signs as well. I found the font that is used in the SOS sign, and it turns out that font has a BUNCH of cool road signs on it. It's called, "Roadgeek 2005." You should search it up, it's pretty neat if you ever need to create some more road signs. On another note, I've noticed that yield signs do exactly what the TODO is having an issue with; detecting right-of-way. I'll take a look at that soon and see how it detects if there's another car in the lane (as when yield signs are enabled, cars do not turn unless it is clear). By the way, I'm at a loss at why trucks and more work-related vehicles refuse to turn on red. |
* It's not perfect, but it's much better than it was.
|
Alright. Other than one final bug against some vehicles not turning on red (the same ones that stop at green lights before continuing, like wtf is up with that? trucks I've noticed do this), this is ready. Wohoo! |
|
Argh... it still not working properly but now in other place. 😭 I think I don't understand that segment ends too... I hope there is no bug up there 😄 |
|
Which place is it not working? I've tried many different roads and it's working for me |
|
Try this: (right hand driving) left and straight are one-way outgoing
|
|
That is the intended behavior. If turning from a one-way road to another one-way road, you are allowed to turn left at red (it's kind of confusing because it draws the wrong sign, but I don't know how I'd be able to detect when it's a left-on-red for one-ways, and quite frankly I think it's unnecessary work). |
|
Isn't it make cutting other vehicles way? Say I am at right lane, as you can see I can't even turn left (lane arrows) It's confusing to me 😕 Better example: |
|
I guess from the outer lane, it would technically be cutting into the inner lane, but I think that's illegal Here's some references.
|
|
Have you tested this on roads with bus and bike lanes? Also, in terms of whether to stop or yield, does it need integrating with the stop/yield/priority signs? |
|
@aubergine10 No, this only applies to traffic lights. By the way, the check for this is in the detection code, not the preferred lane code. Unfortunately I don't know of any way to add it to the preferred lane code, which would prevent the sign from being enabled in that situation. if (hasPriority && (uTargetSegment == uTurnSegment || (currentSegGeo.IsOneWay() && turnSegGeo?.IsOneWay() == true))) {Ok, that's odd, it's letting them turn. Will investigate. |
|
Ok, I understand this and yes option to turn right is visible 😕
|
|
You know, what? I gotchya, mate! Haha, I have no idea why this worked but it did. (It's the same logic as before, just 1) separated and 2) adding a check if the opposing direction is a OutgoingOneWay road. |
|
Yup it's working now. Merging, after almost 80 comments 😄 |
|
Hey, you know, it's worth it to take the time a bugtest! Glad we got it to work! Now it's time for me to move on to my next major project for this mod: Better emergency vehicles, particularly, having cars pull over for them. 🤔 |
|
I know but it's not master branch yet 😉 |
|
I think we've forgot about tram tracks... |
|
That's.. unfortunate. I'll check it out. |
|
Would it be worth releasing the existing stuff (fixed Esc, localisations, icons) to Steam so people have some improvements, and release the Turn on right/left thing as a separate beta mod to allow community to heavily test it (similar to how Loading Screen Mod has two workshop pages)? |
|
Well, actually, it seems that tram tracks also have issues with u-turn and other restrictions. I don't think it's limited to right turns. |
|
Nonetheless it's worth fixing, but I think it needs new issue |
originalfoo
added
the
technical
originalfoo
added
JUNCTION RESTRICTIONS
Reference to VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition#114
Finally learned how to do this. Separated it from all the other stuff in that PR, and then realised the way it was being done was stupid so did it a better way lol
Sorry 'bout my formatter (I just used default VS2017). In the diffs it looks super off center but in Visual Studio it looks fine (different between tabs & spaces)
But here it is, ready to go!
I also snuck in another debug mode for resources, that way we can understand if there's a missing resource or something (when a resource doesn't load, it crashes the entire menu so it doesn't show up. Spent hours debugging just to find out that a resource wasn't loading).