-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Lane Arrows Buttons #387
Conversation
Is it just me or do these buttons look really tacky? They're very... THICK. Can we try making them a little thinner? Or maybe even just match the road texture? |
@FireController1847 you're welcome to suggest better graphics. I am not 100% happy with the disabled lane arrows. |
The second image (comment above) looks vastly improved, and hugely better than current TMPE UI for that feature. Do we need the lane numbers? It's pretty obvious that there is a set of arrows per lane. |
Just a thought. Can we disable/hide buttons for invalid/senseless configurations? If I select "middle lane straight and right", it shouldn't be possible to select "straight and left" for the right lane and "right" for the left lane, because intersections occur. And maybe also hide "left" for the left lane when there's nowhere to turn left - like in the example above. |
The buttons should not disappear. Maybe empty buttons instead? p.s. I am working on GUI which is rendered in the ground plane, it might become a much better replacement for lane arrows GUI than this branch. |
Removal of buttons looks weird. Maybe still have the arrow, greyed out, with no button background? @kvakvs Regarding the GUI rendered on ground plane, that's certainly the direction we want to head in, but be aware there are some weird pitfalls and potential performance issues with that (see PR #282 for examples). |
@aubergine10 The world space UI is rendered via Canvas, i.e. it is constructed once to be a part of the scene, not an overlay rendered every frame. Unity handles that kind of rendering better. |
Is it worth closing this PR considering #391 ? |
I think so, canvas are the future |
Made obsolete by #391 |
Modifies Lane Arrow GUI to contain larger buttons with graphics for ON and OFF for each direction.
P.S. Blue text was temporary it is white again.