-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #509 Main menu Despawning text #529
Conversation
And delete one superfluous "full stop"
Don't edit translation CSV files directly. |
Done. But if doesn't change csv there will be bug. so need to changed translations file. |
One of project admins can build and download CSV from Crowdin and add to your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the translations. Can't run this on the office computer though :)
There's typo in key still "Toolip:Toggle Main Menu" i hope it matches the code and doesn't break anything, and we can rename it later
? Translation.Options.Get("Maintenance.Button:Enable despawning") | ||
: Translation.Options.Get("Maintenance.Checkbox:Disable despawning"); | ||
? Translation.Menu.Get("Tooltip:Enable despawning") | ||
: Translation.Menu.Get("Tooltip:Disable despawning"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no string with key Tooltip:Enable despawning
same for Tooltip:Disable despawning
It has to be introduced in Crowdin before we can accept this
@aubergine10 @krzychu124 please have a quick look, one of you should be enough to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Will do some testing this evening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for your contribution! |
And delete one superfluous "full stop"