Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #509 Main menu Despawning text #529

Merged
merged 4 commits into from
Oct 12, 2019

Conversation

TianQiBuTian
Copy link
Contributor

And delete one superfluous "full stop"

And delete one superfluous "full stop"
@originalfoo originalfoo added the Localisation Localised text and features label Oct 4, 2019
@originalfoo originalfoo added this to the 11.0 milestone Oct 4, 2019
@kvakvs
Copy link
Collaborator

kvakvs commented Oct 6, 2019

Don't edit translation CSV files directly.
Your changes have to go to Crowdin. For this one, a project manager on Crowdin can delete a duplicate string.

@TianQiBuTian
Copy link
Contributor Author

Done. But if doesn't change csv there will be bug. so need to changed translations file.

@kvakvs
Copy link
Collaborator

kvakvs commented Oct 7, 2019

One of project admins can build and download CSV from Crowdin and add to your pull request.
I can do it later after work too.

Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the translations. Can't run this on the office computer though :)
There's typo in key still "Toolip:Toggle Main Menu" i hope it matches the code and doesn't break anything, and we can rename it later

kvakvs
kvakvs previously requested changes Oct 9, 2019
? Translation.Options.Get("Maintenance.Button:Enable despawning")
: Translation.Options.Get("Maintenance.Checkbox:Disable despawning");
? Translation.Menu.Get("Tooltip:Enable despawning")
: Translation.Menu.Get("Tooltip:Disable despawning");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no string with key Tooltip:Enable despawning same for Tooltip:Disable despawning
It has to be introduced in Crowdin before we can accept this

@kvakvs
Copy link
Collaborator

kvakvs commented Oct 12, 2019

@aubergine10 @krzychu124 please have a quick look, one of you should be enough to merge.
I have updated strings again, fixed the missing key, and added new string for keybind not set.

Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@originalfoo
Copy link
Member

Will do some testing this evening.

Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kvakvs kvakvs merged commit 0119259 into CitiesSkylinesMods:master Oct 12, 2019
@kvakvs
Copy link
Collaborator

kvakvs commented Oct 12, 2019

Thanks for your contribution!

@TianQiBuTian TianQiBuTian deleted the bugfix-#509-2 branch July 16, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localisation Localised text and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants