Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decruft SpeedLimitManager.LoadData() logging #736

Merged
merged 4 commits into from
Feb 24, 2020
Merged

Decruft SpeedLimitManager.LoadData() logging #736

merged 4 commits into from
Feb 24, 2020

Conversation

originalfoo
Copy link
Member

@originalfoo originalfoo commented Feb 24, 2020 •
edited
Loading

Fixes #735

  • Encapsulate lane speed limit logging in a debug switch to prevent log spam in DEBUG builds
    • DebugSwitch.SpeedLimits.Get() (switch 26)
  • Remove duplicate logging
  • Remove duplicate Flags.SetLaneSpeedLimit() calls

Code hints showing that Flags is obsolete - is there something else that should be used here?

Also, what is DEBUGLOAD switch doing in this file; old lint? Should it be removed and replaced with DebugSwitch.SpeedLimits.Get() filters?

  • Got rid of the DEBUGLOAD and updated all debug logging in the LoadData() method.

@originalfoo originalfoo added technical Tasks that need to be performed in order to improve quality and maintainability code cleanup Refactor code, remove old code, improve maintainability SPEED LIMITS Feature: Speed limits labels Feb 24, 2020
@originalfoo originalfoo added this to the 11.1.1 milestone Feb 24, 2020
@originalfoo originalfoo self-assigned this Feb 24, 2020
kvakvs
kvakvs approved these changes Feb 24, 2020
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@originalfoo originalfoo changed the title Update SpeedLimitManager.cs Decruft SpeedLimitManager.LoadData() logging Feb 24, 2020
krzychu124
krzychu124 approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@originalfoo originalfoo merged commit c45d953 into master Feb 24, 2020
@originalfoo originalfoo deleted the 735-fix-lane-speed-limit-spam branch February 24, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

Assignees

@originalfoo originalfoo

Labels
code cleanup Refactor code, remove old code, improve maintainability SPEED LIMITS Feature: Speed limits technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.1.1
Development

Successfully merging this pull request may close these issues.

SpeedLimitManager.LoadData log spamming in DEBUG builds
3 participants
@originalfoo @kvakvs @krzychu124