Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduced Simulation Accuracy option #742

Merged
merged 5 commits into from
Feb 29, 2020
Merged

Reintroduced Simulation Accuracy option #742

merged 5 commits into from
Feb 29, 2020

Conversation

krzychu124
Copy link
Member

Resolves #707

  • reintroduced Simulation Accuracy option,
  • fixed double scrollbar issue,
  • updated translations:
    • Spanish - obv,
    • English - kian.zarrin,
    • Hungarian - Krisztián Melich (StummeH)
    • Korean - neinnew,
    • Dutch - Headspike

@krzychu124 krzychu124 added Localisation Localised text and features performance Make it faster! PRIORITY SIGNS Feature: Stop / Yield / Priority signs Settings Road config, mod options, config xml labels Feb 25, 2020
@krzychu124 krzychu124 added this to the 11.1.1 milestone Feb 25, 2020
@krzychu124 krzychu124 self-assigned this Feb 25, 2020
@originalfoo
Copy link
Member

double scrollbar issue?

@krzychu124
Copy link
Member Author

Yeah, my scrollbar fix was merged with bug(invisible before main menu scaler was added), I think

@krzychu124 krzychu124 requested a review from a team February 26, 2020 00:35
@krzychu124 krzychu124 marked this pull request as ready for review February 26, 2020 00:36
originalfoo
originalfoo approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Tested in-game, could change setting with no issues. Scrollbar working as expected.

@originalfoo
Copy link
Member

@kvakvs Look ok to you?

kvakvs
kvakvs reviewed Feb 26, 2020
View reviewed changes
@originalfoo originalfoo mentioned this pull request Feb 26, 2020
Closed
@originalfoo
Copy link
Member

Regarding magic numbers, maybe keep them for now and we can look at reimplementing the settings UI with new form builder that @kvakvs is working on at later date?

@kvakvs
Copy link
Collaborator

kvakvs commented Feb 26, 2020

I am OK if you keep them just raising awareness that there should be more reliable sources for those numbers. Is options menu a regular CO.UI panel with autolayout on? Then we can take it over later.

@krzychu124
Copy link
Member Author

Yes, options container is scrollable so it must have autolayout on.

@originalfoo originalfoo mentioned this pull request Feb 26, 2020
Merged
@krzychu124 krzychu124 requested a review from kvakvs February 27, 2020 12:49
@originalfoo
Copy link
Member

Can we merge this?

kvakvs
kvakvs reviewed Feb 29, 2020
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@krzychu124 krzychu124 merged commit 5c52cff into master Feb 29, 2020
@krzychu124 krzychu124 deleted the 707-reimplement-sim-accuracy branch February 29, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@kianzarrin kianzarrin kianzarrin left review comments

@originalfoo originalfoo originalfoo approved these changes

Assignees

@krzychu124 krzychu124

Labels
Localisation Localised text and features performance Make it faster! PRIORITY SIGNS Feature: Stop / Yield / Priority signs Settings Road config, mod options, config xml
Projects
None yet
Milestone
11.1.1
Development

Successfully merging this pull request may close these issues.

Simulation accuracy option missing in v11
4 participants
@krzychu124 @originalfoo @kvakvs @kianzarrin