fixed lane arrows reset check for lane connections on RHT #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hint: the diff tiny diff is easier to read than the description!
When lane arrow tool reset lanes, it checks if the lanes have lane connections. But in RHT it gets the lane direction wrong. This coupled with #784 causes reset to do nothing if the segment has lane connections on the other side.
Fix:
checked for finalDirection rather than direction.
Test:
create the scenario in the screenshot and press delete.
Expected Result:
without this fix : nothign happens
with this fix: lane arrows are reset