feat: support nydusify for build and push #128
Merged
+149
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aftersnow
previously approved these changes
Mar 18, 2025
BraveY
reviewed
Mar 18, 2025
chlins
force-pushed
the
feat/nydusify
branch
2 times, most recently
from
d2d4dc8 to
70507e8
Compare
Signed-off-by: chlins <chlins.zhang@gmail.com>
BraveY
reviewed
Mar 21, 2025
| @@ -73,5 +75,16 @@ func runBuild(ctx context.Context, workDir string) error { | |||
| } | |||
|
|
|||
| fmt.Printf("Successfully built model artifact: %s\n", buildConfig.Target) | |||
|
|
|||
| // nydusify the model artifact if needed. | |||
| if buildConfig.Nydusify { | |||
There was a problem hiding this comment.
The invocation of nydusify depends on the image that has already been pushed to the image registry using modctl push. Therefore, calling nydusify directly without executing modctl push first is meaningless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an experimental feature to "nydusify" model artifacts in both the build and push processes. The changes include updates to the configurations, command-line flags, and the implementation of the
Nydusifyfunction.New Feature: Nydusify Model Artifacts
Nydusifyflag to the build and push configurations inpkg/config/build.goandpkg/config/push.gorespectively. This flag is used to determine whether to nydusify the model artifact. [1] [2]initfunctions incmd/build.goandcmd/push.goto include the newNydusifyflag and mark it as hidden. [1] [2]Nydusifyfunction inpkg/backend/nydusify.go, which converts a given image to a Nydus image using thenydusifycommand.Build and Push Process Updates
BuildandPushmethods inpkg/backend/build.goandpkg/backend/push.goto call theNydusifyfunction if theNydusifyflag is set. [1] [2]Nydusifyflag can only be used when theOutputRemoteflag is also set in the build configuration.