Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: align with the model-spec v0.0.2 #87

Merged
merged 1 commit into from
Feb 26, 2025
Merged

feat: align with the model-spec v0.0.2 #87

merged 1 commit into from
Feb 26, 2025

Conversation

chlins
Copy link
Contributor

@chlins chlins commented Feb 26, 2025

This pull request includes several updates to the modctl module, primarily focusing on updating dependencies, simplifying code, and improving parameter handling in model configurations.

Dependency Updates:

  • Updated github.com/CloudNativeAI/model-spec dependency from version v0.0.1 to v0.0.2 in go.mod.

Code Simplification:

  • Removed the unused strconv import from pkg/backend/build/build.go.
  • Simplified the buildModelConfig function by directly assigning ParamSize from modelfile instead of parsing it from a string.

Parameter Handling:

  • Updated the Inspect function in pkg/backend/inspect.go to use config.Config.ParamSize directly, improving consistency and readability.

gaius-qi
gaius-qi previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aftersnow
aftersnow previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@aftersnow aftersnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
feat: align with the model-spec v0.0.2
3a99dff 
Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins dismissed stale reviews from aftersnow and gaius-qi via 3a99dff February 26, 2025 12:20
@chlins chlins force-pushed the feat/model-spec-0.0.2 branch from 0a7fe90 to 3a99dff Compare February 26, 2025 12:20
aftersnow
aftersnow approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@aftersnow aftersnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 3775fa8 into main Feb 26, 2025
5 checks passed
@chlins chlins deleted the feat/model-spec-0.0.2 branch February 26, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aftersnow aftersnow aftersnow approved these changes

@gaius-qi gaius-qi gaius-qi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chlins @aftersnow @gaius-qi