-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Podfile DSL] Document how subspecs can be included #235
[Podfile DSL] Document how subspecs can be included #235
Conversation
@@ -112,6 +112,19 @@ module DSL | |||
# | |||
# ------ | |||
# | |||
# ### Subspecs | |||
# | |||
# By default, all of a Pod's default subspecs are installed, unless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not true, only the default subspecs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording is a bit strange in general ( default used twice )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@segiddins That's what I said "default subspecs"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah must've misread it then
3e82b11
to
41e35e9
Compare
I've addressed the feedback. I'm still not completely happy with this, would appreciate any suggestions. |
41e35e9
to
998153d
Compare
# ### Subspecs | ||
# | ||
# When installing a Pod via it's name, it will install all of the | ||
# default subspecs defined in the Pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defined in the podspec?
998153d
to
3182df6
Compare
3182df6
to
44cb307
Compare
[Podfile DSL] Document how subspecs can be included
…specs [Podfile DSL] Document how subspecs can be included
No description provided.