Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Podfile DSL] Document how subspecs can be included #235

Merged

Conversation

kylef
Copy link
Contributor

@kylef kylef commented Apr 6, 2015

No description provided.

@@ -112,6 +112,19 @@ module DSL
#
# ------
#
# ### Subspecs
#
# By default, all of a Pod's default subspecs are installed, unless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not true, only the default subspecs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording is a bit strange in general ( default used twice )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@segiddins That's what I said "default subspecs"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah must've misread it then

@kylef kylef force-pushed the kylef/podfile-pod-subspecs branch from 3e82b11 to 41e35e9 Compare April 6, 2015 02:41
@kylef
Copy link
Contributor Author

kylef commented Apr 6, 2015

I've addressed the feedback. I'm still not completely happy with this, would appreciate any suggestions.

@kylef kylef force-pushed the kylef/podfile-pod-subspecs branch from 41e35e9 to 998153d Compare April 6, 2015 02:42
# ### Subspecs
#
# When installing a Pod via it's name, it will install all of the
# default subspecs defined in the Pod.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined in the podspec?

@kylef kylef force-pushed the kylef/podfile-pod-subspecs branch from 998153d to 3182df6 Compare April 6, 2015 22:51
@kylef kylef force-pushed the kylef/podfile-pod-subspecs branch from 3182df6 to 44cb307 Compare April 6, 2015 22:52
segiddins added a commit that referenced this pull request Apr 7, 2015
[Podfile DSL] Document how subspecs can be included
@segiddins segiddins merged commit a085832 into seg-inline-subspec-dependencies Apr 7, 2015
@segiddins segiddins deleted the kylef/podfile-pod-subspecs branch April 7, 2015 18:37
Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
…specs

[Podfile DSL] Document how subspecs can be included
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants