Add project_header_files DSL to specifications.
#692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
add_project_header_files_dsl
branch
from
6ee85e6 to
eff2caa
Compare
paulb777
approved these changes
Jul 30, 2021
| # headers if no public headers have been specified) to exclude those | ||
| # headers which should not be exposed to the user project and which | ||
| # should not be used to generate the documentation. | ||
| # |
There was a problem hiding this comment.
Does the private_header_files documentation below need to be updated? Or should the private_header_files and project_header_files specifications never overlap?
There was a problem hiding this comment.
I dont think it needs to be updated. I think what we need to specify is that project headers are not copied in the build directory like public or private headers do. Project headers are truly "private" despite the weird naming.
There was a problem hiding this comment.
I see what you are saying though I will update it a bit.
dnkoutso
force-pushed
the
add_project_header_files_dsl
branch
from
eff2caa to
61c30bb
Compare
dnkoutso
force-pushed
the
add_project_header_files_dsl
branch
from
61c30bb to
74d15de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related CocoaPods/CocoaPods#9820