refactor(model): use getOneOrDefault on findDefault

CodeTanzania · Aug 16, 2019 · 1eb254b · 1eb254b
1 parent a1638ed
commit 1eb254b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/priority.model.js b/src/priority.model.js
@@ -297,15 +297,14 @@ PrioritySchema.statics.OPTION_AUTOPOPULATE = OPTION_AUTOPOPULATE;
  * @since 0.1.0
  * @version 1.0.0
  * @static
+ * @deprecated
  */
 PrioritySchema.statics.findDefault = done => {
   // refs
   const Priority = model(MODEL_NAME_PRIORITY);
 
-  // sort priority by weight descending and take one
-  return Priority.findOne()
-    .sort({ weight: 'asc' })
-    .exec(done);
+  // obtain default priority
+  return Priority.getOneOrDefault({}, done);
 };
 
 /**

diff --git a/test/integration/priority.common.spec.js b/test/integration/priority.common.spec.js
@@ -5,16 +5,18 @@ import { Priority } from '../../src/index';
 describe('Priority', () => {
   const jurisdiction = Jurisdiction.fake();
 
-  before(done => clear(Priority, Jurisdiction, done));
+  before(done => clear(done));
 
   before(done => create(jurisdiction, done));
 
   let priority;
   before(done => {
     priority = Priority.fake();
+    priority.default = true;
     priority.jurisdiction = jurisdiction;
     create(priority, done);
   });
+
   describe('static', () => {
     it('should be able to get default', done => {
       Priority.findDefault((error, data) => {
@@ -33,5 +35,5 @@ describe('Priority', () => {
     });
   });
 
-  after(done => clear(Jurisdiction, Priority, done));
+  after(done => clear(done));
 });