Merge pull request #6 from brson/zero-allowance

Fix 0 amount bug in spend_allowance
CometDEX · Mar 28, 2024 · 5f018b4 · 5f018b4
2 parents 16da19d + 59e2715
commit 5f018b4
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/contracts/src/c_pool/allowance.rs b/contracts/src/c_pool/allowance.rs
@@ -57,11 +57,13 @@ pub fn spend_allowance(e: &Env, from: Address, spender: Address, amount: i128) {
     if allowance.amount < amount {
         panic_with_error!(&e, Error::ErrInsufficientAllowance);
     }
-    write_allowance(
-        e,
-        from,
-        spender,
-        allowance.amount - amount,
-        allowance.expiration_ledger,
-    );
+    if amount > 0 {
+        write_allowance(
+            e,
+            from,
+            spender,
+            allowance.amount - amount,
+            allowance.expiration_ledger,
+        );
+    }
 }