Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storageClass vs storageClassName #6

Closed
adlerfaulkner opened this issue Mar 31, 2022 · 2 comments
Closed

storageClass vs storageClassName #6

adlerfaulkner opened this issue Mar 31, 2022 · 2 comments

Comments

@adlerfaulkner
Copy link
Member

persistentVolumeClaim.yaml uses persistence.storageClassName

css-helm-chart/community-solid-server/templates/persistentVolumeClaim.yaml

Line 9 in 1c594eb

storageClassName: {{ .Values.persistence.storageClassName }}

But values.yaml and the README.md use persistence.storageClass

css-helm-chart/community-solid-server/values.yaml

Line 77 in 1c594eb

storageClass: ""

css-helm-chart/community-solid-server/README.md

Line 76 in 1c594eb

| `persistence.storageClass` | CSS persistent volume storage Class | `""` |

Am I not seeing some transformation or is it true that those don't line up?
@MisterTimn
Copy link
Collaborator

Correct, I was using a separate values file for testing which had storageClassName also, hence why this went undetected.
Will change asap!

MisterTimn added a commit that referenced this issue Apr 1, 2022
@MisterTimn
fix: use storageClassName in values.yaml (#6)
ced3408
@MisterTimn
Copy link
Collaborator

MisterTimn commented Apr 26, 2022 •
edited
Loading

Fixed in ced3408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MisterTimn @adlerfaulkner