Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field used in chart is actually ingress.className #10

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

ianconsolata
Copy link
Contributor

The documented field for setting the ingressClassName doesn't match the chart, so update the documentation.

ianconsolata and others added 2 commits June 2, 2022 11:13

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
The documented field for setting the ingressClassName doesn't match the chart, so update the documentation.
@MisterTimn
Copy link
Collaborator

Thanks for the PR! I included the changes in the values.yaml file as well, the values file includes metadata annotations to auto generate the chart parameter documentation with the readme-generator from Bitnami.

Though I wonder if we should use ingress.className or ingres.ingressClassName... the parameter being set in the ingress.yaml template is actually ingressClassName... So that might have my preference.

spec:
{{- if and .Values.ingress.className (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion) }}
ingressClassName: {{ .Values.ingress.className }}
{{- end }}

@ianconsolata
Copy link
Contributor Author

I don't think it matters much which way it gets fixed, as long as the two values match.

Conform to common practice
+ be more transparent as to what field is being manipulated
@MisterTimn MisterTimn merged commit 48446e1 into CommunitySolidServer:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants