Use empty data Incremental Exporter when gvr does not exist #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jframe
reviewed
May 23, 2022
...sts/src/test/java/tech/pegasys/web3signer/tests/keymanager/SlashingProtectionDataChoice.java
Outdated
Show resolved
Hide resolved
...java/tech/pegasys/web3signer/slashingprotection/validator/GenesisValidatorRootValidator.java
Show resolved
Hide resolved
...rotection/src/main/java/tech/pegasys/web3signer/slashingprotection/DbSlashingProtection.java
Show resolved
Hide resolved
siladu
approved these changes
May 23, 2022
|
|
||
| @Override | ||
| public void close() throws Exception { | ||
| outputStream.close(); |
Comment on lines
150
to
152
| if (!gvrValidator.genesisValidatorRootExists()) { | ||
| return new NoOpIncrementalExporter(out); | ||
| } |
There was a problem hiding this comment.
nit: might be nice to create the NoOpIncrementalExporter at the same level as abstraction as before, e.g. by exposing genesisValidatorRootExists to the level above.
The reader would also benefit from the existing comment that explains why we use the noop exporter:
// Using no-op exporter instead of returning an optional so can use try with for closing
There was a problem hiding this comment.
Added a comment. However, exposing checkGVR at SlashingProtection interface would add two level of abstraction i.e. DBSlashing.checkGVR -> gvrValidator.checkGVR. T
jframe
reviewed
May 23, 2022
...rotection/src/main/java/tech/pegasys/web3signer/slashingprotection/DbSlashingProtection.java
Outdated
Show resolved
Hide resolved
siladu
reviewed
May 24, 2022
...egasys/web3signer/core/service/http/handlers/keymanager/delete/DeleteKeystoresProcessor.java
Outdated
Show resolved
Hide resolved
.../pegasys/web3signer/slashingprotection/interchange/NoOpIncrementalInterchangeV5Exporter.java
Outdated
Show resolved
Hide resolved
.../pegasys/web3signer/slashingprotection/interchange/NoOpIncrementalInterchangeV5Exporter.java
Outdated
Show resolved
Hide resolved
.../pegasys/web3signer/slashingprotection/interchange/NoOpIncrementalInterchangeV5Exporter.java
Outdated
Show resolved
Hide resolved
...ain/java/tech/pegasys/web3signer/slashingprotection/interchange/InterchangeJsonProvider.java
Outdated
Show resolved
Hide resolved
...ain/java/tech/pegasys/web3signer/slashingprotection/interchange/InterchangeJsonProvider.java
Outdated
Show resolved
Hide resolved
usmansaleem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Use No Op Incremental Exporter when gvr does not exist. Fixes the issue of delete API where validator was imported without slashing protection data.
Fixed Issue(s)
Fixes #537
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog