You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented Java Resolver for automatic Java installation
Automatic installation of version.json (in process)
PR-Codex overview
This PR introduces new classes and properties related to Java runtime management in the ProjBobcat project, enhancing the ability to download and manage Java resources effectively.
Detailed summary
Added AdditionalArguments property to LaunchSettings.
Introduced JavaDownloadInfo class implementing IGameResource.
Created JavaPlatformManifest, JavaRuntime, Availability, Manifest, Version, JavaDownloadFiles, JavaFile, JreDownload, and StorageType classes for managing Java runtime data.
Implemented JavaInfoResolver class to resolve Java resources asynchronously, including methods for getting runtime and platform information.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
I'm not planning to merge this PR right now because distributing Java executables has potential legal issues. I'll do some further investigation to see if we want to add this to the ProjBobcat library!
I've read different people's opinions on this issue. As I understand it, you cannot automatically install Java from the official website without the end user's approval of their license, but you can automatically install java for Minecraft. The automatic installer that is written here installs java with the Mojang server.
Also, many launchers also install java automatically from the Mojang website. Also, the cmilib.core library, which is a library for running Minecraft in c#, also installs java automatically.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
laolarou726
added
新功能/改进 enhancement
PR-Codex overview
This PR introduces new classes and properties related to Java runtime management in the
ProjBobcatproject, enhancing the ability to download and manage Java resources effectively.Detailed summary
AdditionalArgumentsproperty toLaunchSettings.JavaDownloadInfoclass implementingIGameResource.JavaPlatformManifest,JavaRuntime,Availability,Manifest,Version,JavaDownloadFiles,JavaFile,JreDownload, andStorageTypeclasses for managing Java runtime data.JavaInfoResolverclass to resolve Java resources asynchronously, including methods for getting runtime and platform information.