Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding split_multi_geometries() and a warning for empty gdfs #189

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

nrweir
Copy link
Contributor

@nrweir nrweir commented Jul 9, 2019

Thank you for submitting your PR. Please read the template below, fill it out as appropriate, and make additional changes to your code as needed. Please feel free to submit your PR even if it doesn't satisfy all of the requirements below - simply prepend [WIP] to the PR title until it is ready for review by a maintainer. If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively. After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.

Description

Per @chrieke's points in #187 (thanks again!):

  • implementing split_multi_geometries where I forgot to in vector_tiler.VectorTiler.tile_generator()
  • adding a warning when an empty gdf is made with sol.utils.core._check_gdf()

Eventually I'll clean up the docs per your suggestion, but not yet. I'll open another issue to track it.

Fixes #187

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected - these changes will not be merged until major releases!)

How Has This Been Tested?

Please describe tests that you added to the pytest codebase (if applicable).

Checklist:

  • My PR has a descriptive title
  • My code follows PEP8
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors
  • I have added tests that prove my fix is effective or that my feature works
  • My PR passes Travis CI tests
  • My PR does not reduce coverage in Codecov

If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #189 into dev will increase coverage by 0.01%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #189      +/-   ##
==========================================
+ Coverage   71.31%   71.33%   +0.01%     
==========================================
  Files          65       65              
  Lines        4058     4064       +6     
==========================================
+ Hits         2894     2899       +5     
- Misses       1164     1165       +1
Impacted Files Coverage Δ
solaris/tile/vector_tile.py 84.61% <100%> (+0.4%) ⬆️
solaris/utils/geo.py 71.53% <100%> (+0.21%) ⬆️
solaris/utils/core.py 64.47% <25%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70127f...78f4fba. Read the comment docs.

@nrweir nrweir merged commit 166ac29 into dev Jul 9, 2019
@nrweir nrweir deleted the iss187_tilebugs branch July 9, 2019 02:48
This was referenced Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant