-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean Up Hard-Coded Protocol Changes Distributed Throughout Codebase #3075
Open
ouziel-slama
wants to merge
5
commits into
fairminterv2
Choose a base branch
from
protocolchanges
base: fairminterv2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ouziel-slama
commented
Mar 7, 2025
•
edited
Loading
edited
- Double-check the spelling and grammar of all strings, code comments, etc.
- Double-check that all code is deterministic that needs to be
- Add tests to cover any new or revised logic
- Ensure that the test suite passes
- Update the project release notes
- Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fairminterv2 #3075 +/- ##
================================================
- Coverage 87.41% 87.19% -0.23%
================================================
Files 105 105
Lines 13804 13803 -1
================================================
- Hits 12067 12035 -32
- Misses 1737 1768 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamkrellenstein
approved these changes
Mar 10, 2025
d75f34f
to
3156cfd
Compare
dd729c3
to
69c27c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.