Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Hard-Coded Protocol Changes Distributed Throughout Codebase #3075

Open
wants to merge 5 commits into
base: fairminterv2
Choose a base branch
from

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Mar 7, 2025

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft March 7, 2025 17:31
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.19%. Comparing base (3156cfd) to head (69c27c2).

Files with missing lines Patch % Lines
...rty-core/counterpartycore/lib/messages/issuance.py 42.85% 4 Missing ⚠️
...rparty-core/counterpartycore/lib/messages/order.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           fairminterv2    #3075      +/-   ##
================================================
- Coverage         87.41%   87.19%   -0.23%     
================================================
  Files               105      105              
  Lines             13804    13803       -1     
================================================
- Hits              12067    12035      -32     
- Misses             1737     1768      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ouziel-slama ouziel-slama force-pushed the fairminterv2 branch 2 times, most recently from d75f34f to 3156cfd Compare March 12, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants