Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python Support #147

Merged
merged 9 commits into from
Feb 20, 2023
Merged

Update Python Support #147

merged 9 commits into from
Feb 20, 2023

Conversation

jmsmkn
Copy link
Member

@jmsmkn jmsmkn commented Feb 17, 2023

Removes support for Python 3.6 and 3.7, adds support for Python 3.11.

@jmsmkn
Copy link
Member Author

jmsmkn commented Feb 17, 2023

@pkcakeout Do you know how this would change now that we can finally use dataclasses?

# Paul K.: Trick to get the SLOT-constant through the mypy verification, which
# does not like extra members being added to the a NamedTuple. dataclasses
# would be the correct answer, but are not available in python 3.6 which we need
# for MeVisLab

This was my guess 5466285

@jmsmkn jmsmkn marked this pull request as ready for review February 17, 2023 15:27
@jmsmkn jmsmkn requested a review from pkcakeout February 17, 2023 15:27
@pkcakeout
Copy link
Member

@pkcakeout Do you know how this would change now that we can finally use dataclasses?

# Paul K.: Trick to get the SLOT-constant through the mypy verification, which
# does not like extra members being added to the a NamedTuple. dataclasses
# would be the correct answer, but are not available in python 3.6 which we need
# for MeVisLab

This was my guess 5466285

I think that is it! I actually had a version that was using dataclasses, but I think it is lost. But like I said: I think this was just it!

Copy link
Member

@pkcakeout pkcakeout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's of noise because of the black update, I guess?! Anyway. I did not see anything crazy or wrong...

@jmsmkn jmsmkn merged commit fd2d05f into main Feb 20, 2023
@jmsmkn jmsmkn deleted the pre_commit_update branch February 20, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants