Install the expected version of cryptography instead of pinning it #34932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alopezz
added
changelog/no-changelog
qa/done
github-actions
bot
added
the
short review
iliakur
approved these changes
Mar 10, 2025
|
/merge |
|
View all feedbacks in Devflow UI.
The median merge time in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This cleans up some of what was done in #34619 to build
cryptographyagainst the Agent's OpenSSL on FIPS builds. The main change is dynamically setting the version ofcryptographywe build to match what the integrations expect.Motivation
BARX-668
#34619 left
cryptographypinned to the version matching integrations requirements at that time; that's obviously problematic because it could produce mismatches as integrations bump this dependency and we don't want to keep them in sync manually.Describe how you validated your changes
The build passes and loading cryptography's openssl backend from the Agent's embedded Python works.
Possible Drawbacks / Trade-offs
Additional Notes