Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test bump test-infra #35016

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test bump test-infra #35016

wants to merge 2 commits into from

Conversation

gjulianm
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@gjulianm gjulianm self-assigned this Mar 11, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 11, 2025

[Fast Unit Tests Report]

On pipeline 58462105 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 11, 2025

Uncompressed package size comparison

Comparison with ancestor b04395c3e681cffe693f40336b02473a5ec9af07

Size reduction summary
package diff status size ancestor threshold
datadog-agent-aarch64-rpm -0.00MB 810.56MB 810.56MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 819.59MB 819.59MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 819.59MB 819.59MB 0.50MB
Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 809.79MB 809.79MB 0.50MB
datadog-agent-arm64-deb 0.00MB 800.79MB 800.79MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.33MB 39.33MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.41MB 39.41MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.41MB 39.41MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.85MB 37.85MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.61MB 440.61MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.17MB 62.17MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.24MB 62.24MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.24MB 62.24MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.40MB 59.40MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.47MB 59.47MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 783.29 MiB 801.8 MiB 191.04 MiB 202.62 MiB
static_quality_gate_agent_deb_arm64 774.68 MiB 793.14 MiB 173.15 MiB 184.51 MiB
static_quality_gate_agent_rpm_amd64 783.28 MiB 801.79 MiB 193.12 MiB 205.03 MiB
static_quality_gate_agent_rpm_arm64 774.67 MiB 793.09 MiB 175.42 MiB 186.44 MiB
static_quality_gate_agent_suse_amd64 783.28 MiB 801.81 MiB 193.12 MiB 205.03 MiB
static_quality_gate_agent_suse_arm64 774.67 MiB 793.14 MiB 175.42 MiB 186.44 MiB
static_quality_gate_dogstatsd_deb_amd64 37.58 MiB 47.67 MiB 9.74 MiB 19.78 MiB
static_quality_gate_dogstatsd_deb_arm64 36.18 MiB 46.27 MiB 8.45 MiB 18.49 MiB
static_quality_gate_dogstatsd_rpm_amd64 37.58 MiB 47.67 MiB 9.75 MiB 19.79 MiB
static_quality_gate_dogstatsd_suse_amd64 37.58 MiB 47.67 MiB 9.75 MiB 19.79 MiB
static_quality_gate_iot_agent_deb_amd64 59.36 MiB 69.0 MiB 14.91 MiB 24.8 MiB
static_quality_gate_iot_agent_deb_arm64 56.72 MiB 66.4 MiB 12.88 MiB 22.8 MiB
static_quality_gate_iot_agent_rpm_amd64 59.36 MiB 69.0 MiB 14.93 MiB 24.8 MiB
static_quality_gate_iot_agent_rpm_arm64 56.72 MiB 66.4 MiB 12.87 MiB 22.8 MiB
static_quality_gate_iot_agent_suse_amd64 59.36 MiB 69.0 MiB 14.93 MiB 24.8 MiB
static_quality_gate_docker_agent_amd64 868.43 MiB 886.12 MiB 292.17 MiB 304.21 MiB
static_quality_gate_docker_agent_arm64 883.1 MiB 900.79 MiB 278.51 MiB 290.47 MiB
static_quality_gate_docker_agent_jmx_amd64 1.04 GiB 1.06 GiB 367.28 MiB 379.33 MiB
static_quality_gate_docker_agent_jmx_arm64 1.04 GiB 1.06 GiB 349.6 MiB 361.55 MiB
static_quality_gate_docker_dogstatsd_amd64 45.73 MiB 55.78 MiB 17.24 MiB 27.28 MiB
static_quality_gate_docker_dogstatsd_arm64 44.36 MiB 54.45 MiB 16.12 MiB 26.16 MiB
static_quality_gate_docker_cluster_agent_amd64 264.86 MiB 274.78 MiB 106.29 MiB 116.28 MiB
static_quality_gate_docker_cluster_agent_arm64 280.8 MiB 290.82 MiB 101.13 MiB 111.12 MiB

Copy link

cit-pr-commenter bot commented Mar 11, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7a6eb1bb-9054-4f90-af0c-365eed026c3f

Baseline: b04395c
Comparison: be4c82e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.66 [+0.84, +2.47] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.59 [-0.20, +1.37] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.41 [+0.33, +0.48] 1 Logs
quality_gate_idle_all_features memory utilization +0.23 [+0.14, +0.32] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.19 [+0.11, +0.27] 1 Logs bounds checks dashboard
file_tree memory utilization +0.07 [-0.10, +0.23] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.79, +0.85] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.02 [-0.61, +0.65] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.77, +0.80] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.03] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.65, +0.66] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.30, +0.30] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.81, +0.78] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.89, +0.79] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.15 [-0.61, +0.31] 1 Logs
quality_gate_logs % cpu utilization -0.84 [-3.56, +1.89] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ❌

Please find below the results from static quality gates

Error

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_suse_amd64 DataNotFound 801.81 MiB DataNotFound 205.03 MiB
Gate failure full details
Quality gate Error type Error message
static_quality_gate_agent_suse_amd64 StackTrace Traceback (most recent call last):
File "/go/src/github.com/DataDog/datadog-agent/tasks/quality_gates.py", line 124, in parse_and_trigger_gates
gate_mod.entrypoint(**gate_inputs)
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/static_quality_gate_agent_suse_amd64.py", line 5, in entrypoint
generic_package_agent_quality_gate(
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 69, in generic_package_agent_quality_gate
package_on_wire_size, package_on_disk_size = calculate_package_size(
^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 10, in calculate_package_size
extract_package(ctx=ctx, package_os=package_os, package_path=package_path, extract_dir=extract_dir)
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 72, in extract_package
return extract_rpm_package(ctx, package_path, extract_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 65, in extract_rpm_package
ctx.run(f"rpm2cpio {package_path}
Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 783.77 MiB 801.8 MiB 191.07 MiB 202.62 MiB
static_quality_gate_agent_deb_arm64 775.03 MiB 793.14 MiB 172.91 MiB 184.51 MiB
static_quality_gate_agent_rpm_amd64 783.66 MiB 801.79 MiB 193.15 MiB 205.03 MiB
static_quality_gate_agent_rpm_arm64 775.08 MiB 793.09 MiB 175.38 MiB 186.44 MiB
static_quality_gate_agent_suse_arm64 775.13 MiB 793.14 MiB 175.38 MiB 186.44 MiB
static_quality_gate_dogstatsd_deb_amd64 37.58 MiB 47.67 MiB 9.74 MiB 19.78 MiB
static_quality_gate_dogstatsd_deb_arm64 36.18 MiB 46.27 MiB 8.45 MiB 18.49 MiB
static_quality_gate_dogstatsd_rpm_amd64 37.58 MiB 47.67 MiB 9.75 MiB 19.79 MiB
static_quality_gate_dogstatsd_suse_amd64 37.58 MiB 47.67 MiB 9.75 MiB 19.79 MiB
static_quality_gate_iot_agent_deb_amd64 59.37 MiB 69.0 MiB 14.91 MiB 24.8 MiB
static_quality_gate_iot_agent_deb_arm64 56.72 MiB 66.4 MiB 12.88 MiB 22.8 MiB
static_quality_gate_iot_agent_rpm_amd64 59.37 MiB 69.0 MiB 14.94 MiB 24.8 MiB
static_quality_gate_iot_agent_rpm_arm64 56.72 MiB 66.4 MiB 12.87 MiB 22.8 MiB
static_quality_gate_iot_agent_suse_amd64 59.37 MiB 69.0 MiB 14.94 MiB 24.8 MiB
static_quality_gate_docker_agent_amd64 868.43 MiB 886.12 MiB 292.17 MiB 304.21 MiB
static_quality_gate_docker_agent_arm64 883.1 MiB 900.79 MiB 278.51 MiB 290.47 MiB
static_quality_gate_docker_agent_jmx_amd64 1.04 GiB 1.06 GiB 367.28 MiB 379.33 MiB
static_quality_gate_docker_agent_jmx_arm64 1.04 GiB 1.06 GiB 349.6 MiB 361.55 MiB
static_quality_gate_docker_dogstatsd_amd64 45.73 MiB 55.78 MiB 17.24 MiB 27.28 MiB
static_quality_gate_docker_dogstatsd_arm64 44.36 MiB 54.45 MiB 16.12 MiB 26.16 MiB
static_quality_gate_docker_cluster_agent_amd64 264.86 MiB 274.78 MiB 106.29 MiB 116.28 MiB
static_quality_gate_docker_cluster_agent_arm64 280.8 MiB 290.82 MiB 101.13 MiB 111.12 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant