Fix upload of ELF dynamic symbols #1579
Merged
+77
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsavoire
force-pushed
the
nsavoire/fix_elf_dynamic_symbols
branch
from
3f1b9a4 to
9280a87
Compare
nsavoire
added
bug
Datadog ReportBranch report: ✅ 0 Failed, 2685 Passed, 0 Skipped, 1m 51.94s Total duration (37.55s time saved) |
nsavoire
force-pushed
the
nsavoire/fix_elf_dynamic_symbols
branch
3 times, most recently
from
fb3ddbd to
a4ced2f
Compare
rtrieu
approved these changes
Mar 10, 2025
Use zstd if available to compress debug sections in ELF files, otherwise default to zlib.
nsavoire
force-pushed
the
nsavoire/fix_elf_dynamic_symbols
branch
from
de93a96 to
51450f8
Compare
nsavoire
force-pushed
the
nsavoire/fix_elf_dynamic_symbols
branch
from
51450f8 to
37dcfdf
Compare
Gandem
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
objcopy --only-keep-debugunexpectedly removes.dynsymand.dynstrsections. This leads to datadog-ci uplaoding ELF files with no symbol information when only dynamic symbols are available.How?
This PR workaround this by first dumping these sections to files with
objcopy --dump-sectionand adding them back withobjcopy --add-section.Other changes (separate commits):
objcopysupported targets listingNOBITS): this what caused tests checking for dynamic symbol extraction to incorrectly succeedzlib-gnucompression (.zdebug_infosection)Review checklist