Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky batching stage test #112

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix flaky batching stage test #112

merged 1 commit into from
Mar 19, 2025

Conversation

nsavoire
Copy link
Collaborator

What does this PR do?

Fix flaky batching stage test:

  • Ensure there is only one timer active at a time
  • Ensure the timer has been reset (by blocking for waiters) before advancing the fake clock

@nsavoire nsavoire requested a review from a team as a code owner March 18, 2025 23:02
@nsavoire nsavoire force-pushed the nsavoire/fix_flaky_test branch from d44d6d0 to e62587c Compare March 18, 2025 23:10
* Ensure there is only one timer active at a time
* Use synchronous input channel to ensure all input is processed before advancing the clock
@nsavoire nsavoire force-pushed the nsavoire/fix_flaky_test branch from e62587c to 393c156 Compare March 19, 2025 11:06
@nsavoire nsavoire merged commit 2ad56ba into main Mar 19, 2025
9 checks passed
@nsavoire nsavoire deleted the nsavoire/fix_flaky_test branch March 19, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants