Add symbol uploader tests #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsavoire
force-pushed
the
nsavoire/add_symbol_uploader_tests
branch
from
a8d252e to
d5d9906
Compare
Gandem
reviewed
Mar 19, 2025
pclntab/pclntab.go
Outdated
| @@ -586,7 +587,7 @@ func findGoPCLnTab(ef *pfelf.File, additionalChecks bool) (goPCLnTabInfo *GoPCLn | |||
| // gopclntab parsing code might panic if the data is corrupt. | |||
| defer func() { | |||
| if r := recover(); r != nil { | |||
| err = fmt.Errorf("panic while searching pclntab: %v", r) | |||
| err = fmt.Errorf("panic while searching pclntab: %v, stack:\n%s", r, debug.Stack()) | |||
There was a problem hiding this comment.
Since failing to extract gopclntab is an info log, and not a debug log, I'd recommend against printing the stack here. I think customers would be confused seeing a fully printed stack in their info logs
There was a problem hiding this comment.
Removed stack printing
Gandem
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add various test cases for symbol uploader.
Fix wrong symbol source when uploading Go binary with an error during pclntab extraction.