Skip to content

Commit fdf2505

Browse files
authored
[Crashtracking] Tag reports with is_crash: true (#6568)
## Summary of changes Add `is_crash:true` tag to crash reports. ## Reason for change This is the accepted way to identify crash reports, but I completely forgot to implement it. ## Implementation details Added a tag. ## Test coverage Added an assertion in the crashtracking tests.
1 parent 7925730 commit fdf2505

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

profiler/src/ProfilerEngine/Datadog.Profiler.Native/CrashReporting.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ int32_t CrashReporting::Initialize()
7777
return 1;
7878
}
7979

80-
return AddTag("severity", "crash");
80+
AddTag("severity", "crash");
81+
return AddTag("is_crash", "true");
8182
}
8283

8384
void CrashReporting::SetLastError(ddog_Error error)

tracer/test/Datadog.Trace.Tools.dd_dotnet.ArtifactTests/CreatedumpTests.cs

+1
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,7 @@ public async Task WriteCrashReport()
274274
File.Exists(reportFile.Path).Should().BeTrue();
275275

276276
var report = JObject.Parse(reportFile.GetContent());
277+
report["tags"]["is_crash"].Value<string>().Should().Be("true");
277278

278279
var metadataTags = (JArray)report["metadata"]!["tags"];
279280

0 commit comments

Comments
 (0)