Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crashtracking] Tag reports with is_crash: true #6568

Merged
merged 2 commits into from
Jan 20, 2025
Merged

[Crashtracking] Tag reports with is_crash: true #6568

merged 2 commits into from
Jan 20, 2025

Conversation

kevingosse
Copy link
Collaborator

@kevingosse kevingosse commented Jan 17, 2025 •
edited
Loading

Summary of changes

Add is_crash:true tag to crash reports.

Reason for change

This is the accepted way to identify crash reports, but I completely forgot to implement it.

Implementation details

Added a tag.

Test coverage

Added an assertion in the crashtracking tests.

@kevingosse kevingosse requested review from a team as code owners January 17, 2025 10:07
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 17, 2025 •
edited
Loading

Datadog Report

Branch report: kevin/crashtracking_iscrash
Commit report: fef645d
Test service: dd-trace-dotnet

✅ 0 Failed, 244031 Passed, 2442 Skipped, 20h 44m 16.14s Total Time

@andrewlock
Copy link
Member

andrewlock commented Jan 17, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6568) - mean (69ms)  : 66, 73
     .   : milestone, 69,
    master - mean (69ms)  : 65, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6568) - mean (983ms)  : 959, 1007
     .   : milestone, 983,
    master - mean (987ms)  : 962, 1013
     .   : milestone, 987,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6568) - mean (107ms)  : 105, 110
     .   : milestone, 107,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6568) - mean (680ms)  : 665, 695
     .   : milestone, 680,
    master - mean (681ms)  : 668, 695
     .   : milestone, 681,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6568) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6568) - mean (633ms)  : 619, 648
     .   : milestone, 633,
    master - mean (635ms)  : 620, 650
     .   : milestone, 635,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6568) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6568) - mean (1,093ms)  : 1062, 1125
     .   : milestone, 1093,
    master - mean (1,087ms)  : 1060, 1114
     .   : milestone, 1087,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6568) - mean (275ms)  : 271, 280
     .   : milestone, 275,
    master - mean (276ms)  : 270, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6568) - mean (870ms)  : 841, 899
     .   : milestone, 870,
    master - mean (863ms)  : 839, 886
     .   : milestone, 863,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6568) - mean (264ms)  : 261, 268
     .   : milestone, 264,
    master - mean (264ms)  : 260, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6568) - mean (849ms)  : 818, 880
     .   : milestone, 849,
    master - mean (847ms)  : 808, 886
     .   : milestone, 847,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6568 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.168
  • 2 benchmarks are slower, with geometric mean 1.143
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.08μs 44.7ns 268ns 0.0241 0.0121 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 53.2ns 271ns 0.02 0.01 0 5.8 KB
master StartStopWithChild net472 16.4μs 56.2ns 210ns 1.04 0.294 0.0981 6.21 KB
#6568 StartStopWithChild net6.0 8.17μs 43.8ns 227ns 0.0121 0.00402 0 5.61 KB
#6568 StartStopWithChild netcoreapp3.1 10.2μs 56.4ns 361ns 0.0244 0.00975 0 5.8 KB
#6568 StartStopWithChild net472 16.6μs 43.9ns 170ns 1.03 0.295 0.0821 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 491μs 242ns 873ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 961ns 3.72μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 858μs 756ns 2.93μs 0.428 0 0 3.3 KB
#6568 WriteAndFlushEnrichedTraces net6.0 507μs 342ns 1.32μs 0 0 0 2.7 KB
#6568 WriteAndFlushEnrichedTraces netcoreapp3.1 658μs 707ns 2.65μs 0 0 0 2.7 KB
#6568 WriteAndFlushEnrichedTraces net472 861μs 410ns 1.59μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6568

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1 1.166 169,948.47 145,730.11
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0 1.147 151,772.44 132,313.42

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 151μs 852ns 6.08μs 0.156 0 0 14.47 KB
master SendRequest netcoreapp3.1 173μs 1.21μs 12μs 0.174 0 0 17.27 KB
master SendRequest net472 0.000778ns 0.000395ns 0.00148ns 0 0 0 0 b
#6568 SendRequest net6.0 132μs 198ns 740ns 0.174 0 0 14.47 KB
#6568 SendRequest netcoreapp3.1 146μs 253ns 947ns 0.218 0 0 17.27 KB
#6568 SendRequest net472 0.00491ns 0.00257ns 0.00995ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 595μs 3.05μs 23.7μs 0.546 0 0 41.74 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 688μs 4.24μs 41.8μs 0.314 0 0 41.78 KB
master WriteAndFlushEnrichedTraces net472 877μs 3.14μs 12.2μs 8.19 2.59 0.431 53.26 KB
#6568 WriteAndFlushEnrichedTraces net6.0 578μs 2.72μs 15.4μs 0.635 0 0 41.63 KB
#6568 WriteAndFlushEnrichedTraces netcoreapp3.1 666μs 3.29μs 24.4μs 0.326 0 0 41.63 KB
#6568 WriteAndFlushEnrichedTraces net472 823μs 3.79μs 14.2μs 8.22 2.47 0.411 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.35μs 0.923ns 3.57ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.71μs 1.47ns 5.3ns 0.0136 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 1.64ns 5.91ns 0.156 0.00105 0 987 B
#6568 ExecuteNonQuery net6.0 1.34μs 1.1ns 4.26ns 0.0141 0 0 1.02 KB
#6568 ExecuteNonQuery netcoreapp3.1 1.83μs 1.56ns 6.04ns 0.0134 0 0 1.02 KB
#6568 ExecuteNonQuery net472 2.05μs 1.01ns 3.48ns 0.157 0.00103 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 0.53ns 2.05ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.707ns 2.64ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.51μs 2.67ns 10.3ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.3μs 0.481ns 1.73ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 0.727ns 2.62ns 0.0137 0 0 1.02 KB
master CallElasticsearchAsync net472 2.58μs 1.95ns 7.54ns 0.166 0 0 1.05 KB
#6568 CallElasticsearch net6.0 1.29μs 1.02ns 3.83ns 0.0135 0 0 976 B
#6568 CallElasticsearch netcoreapp3.1 1.59μs 0.592ns 2.21ns 0.0128 0 0 976 B
#6568 CallElasticsearch net472 2.59μs 1.53ns 5.52ns 0.157 0 0 995 B
#6568 CallElasticsearchAsync net6.0 1.33μs 0.52ns 1.95ns 0.0134 0 0 952 B
#6568 CallElasticsearchAsync netcoreapp3.1 1.62μs 0.494ns 1.71ns 0.0139 0 0 1.02 KB
#6568 CallElasticsearchAsync net472 2.67μs 1.99ns 7.69ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.38μs 0.697ns 2.61ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.67μs 0.966ns 3.74ns 0.0124 0 0 952 B
master ExecuteAsync net472 1.77μs 0.384ns 1.39ns 0.145 0 0 915 B
#6568 ExecuteAsync net6.0 1.24μs 0.802ns 3.1ns 0.0136 0 0 952 B
#6568 ExecuteAsync netcoreapp3.1 1.59μs 1.37ns 5.33ns 0.0128 0 0 952 B
#6568 ExecuteAsync net472 1.83μs 0.475ns 1.78ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.39μs 0.987ns 3.69ns 0.0329 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.29μs 5.34ns 18.5ns 0.0369 0 0 2.85 KB
master SendAsync net472 7.39μs 0.947ns 3.67ns 0.494 0 0 3.12 KB
#6568 SendAsync net6.0 4.38μs 2.12ns 8.19ns 0.0309 0 0 2.31 KB
#6568 SendAsync netcoreapp3.1 5.14μs 1.88ns 7.04ns 0.0386 0 0 2.85 KB
#6568 SendAsync net472 7.49μs 2.23ns 8.36ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.932ns 3.49ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.18μs 1.21ns 4.7ns 0.0228 0 0 1.64 KB
master EnrichedLog net472 2.65μs 1.47ns 5.68ns 0.249 0 0 1.57 KB
#6568 EnrichedLog net6.0 1.46μs 0.935ns 3.5ns 0.0232 0 0 1.64 KB
#6568 EnrichedLog netcoreapp3.1 2.21μs 0.881ns 3.29ns 0.0221 0 0 1.64 KB
#6568 EnrichedLog net472 2.55μs 1.21ns 4.69ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 115μs 109ns 421ns 0.0576 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 121ns 453ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 75.8ns 294ns 0.678 0.226 0 4.46 KB
#6568 EnrichedLog net6.0 115μs 107ns 415ns 0.0575 0 0 4.28 KB
#6568 EnrichedLog netcoreapp3.1 120μs 80.1ns 300ns 0.0606 0 0 4.28 KB
#6568 EnrichedLog net472 151μs 65.7ns 255ns 0.678 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.96μs 0.973ns 3.77ns 0.0299 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.19μs 1.24ns 4.8ns 0.0293 0 0 2.2 KB
master EnrichedLog net472 4.83μs 1.47ns 5.69ns 0.321 0 0 2.02 KB
#6568 EnrichedLog net6.0 2.9μs 1.11ns 4.28ns 0.0305 0 0 2.2 KB
#6568 EnrichedLog netcoreapp3.1 4.17μs 5.57ns 20.8ns 0.029 0 0 2.2 KB
#6568 EnrichedLog net472 4.86μs 1.07ns 4ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.34μs 0.801ns 3ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 0.896ns 3.11ns 0.015 0 0 1.14 KB
master SendReceive net472 2.09μs 1.03ns 3.99ns 0.183 0 0 1.16 KB
#6568 SendReceive net6.0 1.39μs 1.77ns 6.61ns 0.016 0 0 1.14 KB
#6568 SendReceive netcoreapp3.1 1.87μs 1.05ns 4.06ns 0.0159 0 0 1.14 KB
#6568 SendReceive net472 2.09μs 1.04ns 4.05ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.8μs 3.87ns 15ns 0.0225 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.97μs 2.68ns 10.4ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.45μs 3.12ns 12.1ns 0.323 0 0 2.04 KB
#6568 EnrichedLog net6.0 2.79μs 0.716ns 2.68ns 0.0223 0 0 1.6 KB
#6568 EnrichedLog netcoreapp3.1 3.91μs 3.19ns 12.4ns 0.0217 0 0 1.65 KB
#6568 EnrichedLog net472 4.45μs 3.06ns 11.8ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6568

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.170 805.87 943.08
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.116 591.06 659.92

Faster 🎉 in #6568

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.191 474.83 398.74

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 475ns 0.246ns 0.953ns 0.00797 0 0 576 B
master StartFinishSpan netcoreapp3.1 591ns 0.527ns 2.04ns 0.00777 0 0 576 B
master StartFinishSpan net472 678ns 0.191ns 0.74ns 0.0918 0 0 578 B
master StartFinishScope net6.0 532ns 0.291ns 1.13ns 0.00967 0 0 696 B
master StartFinishScope netcoreapp3.1 821ns 0.75ns 2.9ns 0.00901 0 0 696 B
master StartFinishScope net472 806ns 0.447ns 1.73ns 0.104 0 0 658 B
#6568 StartFinishSpan net6.0 399ns 0.151ns 0.545ns 0.00807 0 0 576 B
#6568 StartFinishSpan netcoreapp3.1 659ns 0.603ns 2.33ns 0.00781 0 0 576 B
#6568 StartFinishSpan net472 698ns 0.28ns 1.09ns 0.0916 0 0 578 B
#6568 StartFinishScope net6.0 543ns 0.404ns 1.57ns 0.00979 0 0 696 B
#6568 StartFinishScope netcoreapp3.1 755ns 0.627ns 2.43ns 0.00954 0 0 696 B
#6568 StartFinishScope net472 938ns 1.93ns 7.46ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 678ns 0.203ns 0.761ns 0.00985 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 869ns 0.483ns 1.87ns 0.00926 0 0 696 B
master RunOnMethodBegin net472 1.1μs 0.753ns 2.92ns 0.104 0 0 658 B
#6568 RunOnMethodBegin net6.0 658ns 0.237ns 0.853ns 0.0099 0 0 696 B
#6568 RunOnMethodBegin netcoreapp3.1 876ns 0.74ns 2.87ns 0.00924 0 0 696 B
#6568 RunOnMethodBegin net472 1.08μs 0.652ns 2.52ns 0.105 0 0 658 B

@kevingosse kevingosse force-pushed the kevin/crashtracking_iscrash branch from 9c205ab to fef645d Compare January 17, 2025 14:58
gleocadie
gleocadie approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevingosse kevingosse merged commit fdf2505 into master Jan 20, 2025
68 of 74 checks passed
@kevingosse kevingosse deleted the kevin/crashtracking_iscrash branch January 20, 2025 10:55
chrisnas
chrisnas approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@chrisnas chrisnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added this to the vNext-v3 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisnas chrisnas chrisnas approved these changes

@gleocadie gleocadie gleocadie approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:crashtracking
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kevingosse @andrewlock @chrisnas @gleocadie