use async/await when instrumenting asynchronous methods (redux) #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaspimentel
added
type:bug
area:automatic-instrumentation
|
The Elasticsearch tests fail on Windows because we don't have an Elasticsearch server to connect to. The same tests pass on Linux and on my local Windows machine. I'll figure out how to run these tests on Windows CI soon. |
bmermet
reviewed
Nov 19, 2018
| @@ -49,34 +58,58 @@ public static T ExecuteSyncImpl<T>(object multiplexer, object message, object pr | |||
| /// <param name="server">The server to call.</param> | |||
| /// <returns>An asynchronous task.</returns> | |||
| public static object ExecuteAsyncImpl<T>(object multiplexer, object message, object processor, object state, object server) | |||
| { | |||
| return ExecuteAsyncImplInternal<T>(multiplexer, message, processor, state, server); | |||
There was a problem hiding this comment.
What is the purpose of forwarding the call to ExecuteAsyncImplInternal that takes exactly the same arguments?
There was a problem hiding this comment.
The "internal" methods use async/await which require a return type of Task or Task<T>, but we inject methods with object return type. The method signatures must match (including the return type), which is why I split them into 2 methods.
bmermet
approved these changes
Nov 19, 2018
lucaspimentel
added a commit
that referenced
this pull request
Nov 19, 2018
* clean up code * use async/awaot instead of `Span.Trace()` in Web API integration * use async/awaot instead of `Span.Trace()` in StackExchange.Redis integration * use async/await instead of `Span.Trace()` in ServiceStack.Redis integration * use async/await instead of `Span.Trace()` in Elasticsearch integration * remove unused optional parameters * remove unused extension method `Span.Trace()` * use specific method return type instead of `object`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The main goal of this PR is to avoid wrapping exceptions in an
AggregateExceptionwhen instrumenting asynchronous methods.Changes
I inlined all uses of extension method
Span.Trace()and usedasync/awaitinstead ofTask.ContinueWith()to close spans after async tasks are completed.Result
This changes provide better handling of
TaskandTask<T>overall, with cleaner code (no callbacks!) that doesn't wrap exceptions and ensures spans are not disposed before aTaskfinishes.