[OpenTracing] allow setting service name after span is created #229
+174
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaspimentel
changed the title
palazzem
approved these changes
Dec 6, 2018
lucaspimentel
deleted the
lpimentel/add-opentracing-service-name-unit-tests
branch
bmermet
reviewed
Dec 6, 2018
| public string ServiceName | ||
| { | ||
| get { return _context.ServiceName; } | ||
| internal set { _context.ServiceName = value; } |
There was a problem hiding this comment.
I'm late to the party sorry, but why not let the non opentracing tracer change the service name too?
There was a problem hiding this comment.
You're right, there's nothing stopping us from allowing that as well. We just need to drop internal here. I was trying to fix the blocking issue only without changing anything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a span's service name to be changed with
ISpan.SetTag()after the span is created. Setting the service name before a span is created was already supported withISpanBuilder.WithTag().See #182.